Page MenuHomeClusterLabs Projects
Feed Advanced Search

Mar 5 2025

clumens committed rPae44688df3d7: Refactor: python: Disable the similar code warning from pylintrc. (authored by clumens).
Refactor: python: Disable the similar code warning from pylintrc.
Mar 5 2025, 2:28 PM
clumens committed rPe36b4b8bccd8: Build: cts: Add cts-cli to the python_files list. (authored by clumens).
Build: cts: Add cts-cli to the python_files list.
Mar 5 2025, 2:28 PM
clumens committed rP301e4678e8e0: Refactor: cts: Fix a pyflake whitespace problem in cts-cli. (authored by clumens).
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
Mar 5 2025, 2:28 PM
clumens committed rPf69c484027a7: Refactor: cts: Replace {shadow} strings in cts-cli where possible. (authored by clumens).
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
Mar 5 2025, 2:28 PM
clumens committed rP59114640d618: Refactor: cts: Use {cts_cli_data} as an f-string where possible. (authored by clumens).
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
Mar 5 2025, 2:28 PM
clumens committed rPc21b30b014e0: Refactor: cts: Remove unnecessary whitespace from the end of commands. (authored by clumens).
Refactor: cts: Remove unnecessary whitespace from the end of commands.
Mar 5 2025, 2:28 PM
clumens committed rP63e78fbf4622: Build: Run cts-cli verbosely. (authored by clumens).
Build: Run cts-cli verbosely.
Mar 5 2025, 11:28 AM
clumens committed rP50e9864f6899: Test: CTS: Pass verbose argument to the diff function. (authored by clumens).
Test: CTS: Pass verbose argument to the diff function.
Mar 5 2025, 11:28 AM
clumens committed rPf39e0e2f6f2d: API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG. (authored by clumens).
API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG.
Mar 5 2025, 11:28 AM
clumens committed rPc1aa2c722e62: Med: cts: Add missing crm_simulate regression tests back to cts-cli. (authored by clumens).
Med: cts: Add missing crm_simulate regression tests back to cts-cli.
Mar 5 2025, 11:28 AM
clumens committed rP2380d2b99e7a: Log: pacemaker-based: improve messages when reading CIB from disk (authored by kgaillot).
Log: pacemaker-based: improve messages when reading CIB from disk
Mar 5 2025, 11:28 AM
clumens committed rPeb1081cf0e37: Log: pacemaker-based: improve exit messages (authored by kgaillot).
Log: pacemaker-based: improve exit messages
Mar 5 2025, 11:28 AM
clumens committed rP9ca219f2aac8: Log: controller: simplify join finalization messages (authored by kgaillot).
Log: controller: simplify join finalization messages
Mar 5 2025, 11:28 AM
clumens committed rP7747df0fb7a0: Log: pacemaker-based: improve a few messages (authored by kgaillot).
Log: pacemaker-based: improve a few messages
Mar 5 2025, 11:28 AM
clumens committed rP8eab0af5ad98: Log: controller: drop dot file logs (authored by kgaillot).
Log: controller: drop dot file logs
Mar 5 2025, 11:28 AM
clumens committed rP3cbec72bf4a5: Log: controller: improve start-up/exit messages (authored by kgaillot).
Log: controller: improve start-up/exit messages
Mar 5 2025, 11:28 AM
clumens committed rP97584ad1f289: Log: controller: improve resource action execution logs (authored by kgaillot).
Log: controller: improve resource action execution logs
Mar 5 2025, 11:28 AM
clumens committed rPc5ee89910c75: Build: devel: Add additional cppcheck arguments. (authored by clumens).
Build: devel: Add additional cppcheck arguments.
Mar 5 2025, 11:28 AM
clumens committed rPe636645eef86: Refactor: libs: Remove existing cppcheck suppressions. (authored by clumens).
Refactor: libs: Remove existing cppcheck suppressions.
Mar 5 2025, 11:28 AM
clumens committed rP9a4a52c47bd0: Refactor: daemons: Simplify some code in start_child. (authored by clumens).
Refactor: daemons: Simplify some code in start_child.
Mar 5 2025, 11:28 AM
clumens committed rPe31c9a8667e7: Refactor: libs: Add a couple new cppcheck suppressions. (authored by clumens).
Refactor: libs: Add a couple new cppcheck suppressions.
Mar 5 2025, 11:28 AM
clumens committed rP20bc479523c5: Build: Fix coverage targets. (authored by clumens).
Build: Fix coverage targets.
Mar 5 2025, 11:28 AM

Feb 19 2025

clumens claimed T903: Split large IPC messages.
Feb 19 2025, 3:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens changed the status of T903: Split large IPC messages from Open to WIP.
Feb 19 2025, 3:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 18 2025

clumens triaged T973: Get rid of "non-option ARGV-elements" blocks from tools as Wishlist priority.
Feb 18 2025, 3:41 PM · Restricted Project, Pacemaker: Tools
clumens triaged T972: cts-cli shouldn't write to /tmp during package builds as Low priority.
Feb 18 2025, 1:33 PM · Restricted Project
clumens added a comment to T901: Use asynchronous communication for liblrmd commands with replies.

This is going to be very, very difficult to do which is why we've removed it from the RHEL board and lowered the priority. Basically, lrmd_send_command implements almost all of the API commands for a lrmd_t. All of those would need to be converted over to an async style, and then all of their callers would be. This includes major portions of the control daemon, which isn't very well set up to call the async versions of these functions. It would require rewriting much of liblrmd and the control daemon, and there's simply not enough time to get around to a project of that size.

Feb 18 2025, 1:24 PM · Restricted Project, Restricted Project
clumens added a comment to T775: Evaluate replacing pcmk__realloc() with GLib functions.

cppcheck appears to be fine with pcmk__realloc for me, but I would still be all for investigating removing it in favor of someone else's code.

Feb 18 2025, 1:10 PM · Restricted Project, Pacemaker: Libraries

Feb 17 2025

clumens committed rPc8ea0e8e32f9: Build: devel: Replace indent with clang-format. (authored by clumens).
Build: devel: Replace indent with clang-format.
Feb 17 2025, 3:56 PM

Feb 6 2025

clumens updated the task description for T970: Decrease code duplication in cts regression tests.
Feb 6 2025, 3:38 PM · Restricted Project
clumens changed the edit policy for T970: Decrease code duplication in cts regression tests.
Feb 6 2025, 3:31 PM · Restricted Project

Feb 5 2025

clumens committed rP02b1a18c1130: Refactor: libcrmservice: systemd_init should return a bool. (authored by clumens).
Refactor: libcrmservice: systemd_init should return a bool.
Feb 5 2025, 3:44 PM
clumens committed rP9138d96d027b: Refactor: daemons: Fix whitespace problems in execd_commands.c. (authored by clumens).
Refactor: daemons: Fix whitespace problems in execd_commands.c.
Feb 5 2025, 3:44 PM
clumens committed rP96e9f97e4926: Refactor: daemons: Unindent a block of code in action_complete. (authored by clumens).
Refactor: daemons: Unindent a block of code in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP9151b51c50b1: Refactor: daemons: Get rid of an unnecessary #endif/#ifdef. (authored by clumens).
Refactor: daemons: Get rid of an unnecessary #endif/#ifdef.
Feb 5 2025, 3:44 PM
clumens committed rP7874bce94ba8: Refactor: daemons: Unindent the goagain block in action_complete. (authored by clumens).
Refactor: daemons: Unindent the goagain block in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP51a93e771656: Low: libcrmservices: Don't leak msg if systemd_proxy is NULL. (authored by clumens).
Low: libcrmservices: Don't leak msg if systemd_proxy is NULL.
Feb 5 2025, 3:44 PM
clumens committed rP96e9bff3ff7b: Refactor: daemons: Improve whitespace in action_complete. (authored by clumens).
Refactor: daemons: Improve whitespace in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP4a4e721520a7: Refactor: libcrmservices: Unref the dbus connection... (authored by clumens).
Refactor: libcrmservices: Unref the dbus connection...
Feb 5 2025, 3:44 PM

Feb 3 2025

clumens triaged T971: Store inflight and blocked ops in a hash table as Wishlist priority.
Feb 3 2025, 2:55 PM · Restricted Project
clumens committed rPe8ab7135f77f: Low: python: Add python value for new CRM_EX_NO_DC exit code. (authored by clumens).
Low: python: Add python value for new CRM_EX_NO_DC exit code.
Feb 3 2025, 2:46 PM
clumens committed rP2e109a7950bb: Refactor: python: Rename variables in Audit __call__ methods. (authored by clumens).
Refactor: python: Rename variables in Audit __call__ methods.
Feb 3 2025, 2:42 PM
clumens committed rP3eb9450fa20b: Refactor: python: Reduce code duplication looking for core dumps. (authored by clumens).
Refactor: python: Reduce code duplication looking for core dumps.
Feb 3 2025, 2:42 PM
clumens committed rPb9b5eab3c2d9: Low: python: Use coredumpctl to check for core files. (authored by clumens).
Low: python: Use coredumpctl to check for core files.
Feb 3 2025, 2:42 PM
clumens committed rP35d58504c48c: Refactor: cts: _find_core_on_fs can now take a list of locations. (authored by clumens).
Refactor: cts: _find_core_on_fs can now take a list of locations.
Feb 3 2025, 2:42 PM

Jan 31 2025

clumens added subtasks for T970: Decrease code duplication in cts regression tests: T846: Move cts-cli validity and upgrade tests to cts-schemas, Unknown Object (Maniphest Task), Unknown Object (Maniphest Task), Unknown Object (Maniphest Task).
Jan 31 2025, 3:59 PM · Restricted Project
clumens added a parent task for T846: Move cts-cli validity and upgrade tests to cts-schemas: T970: Decrease code duplication in cts regression tests.
Jan 31 2025, 3:59 PM · Pacemaker, Restricted Project
clumens added a subtask for T970: Decrease code duplication in cts regression tests: Unknown Object (Maniphest Task).
Jan 31 2025, 3:57 PM · Restricted Project
clumens triaged T970: Decrease code duplication in cts regression tests as Wishlist priority.
Jan 31 2025, 3:57 PM · Restricted Project

Jan 30 2025

clumens edited the content of Patch Review.
Jan 30 2025, 4:59 PM
clumens edited the content of Patch Review.
Jan 30 2025, 2:10 PM
clumens created an object: Patch Review.
Jan 30 2025, 2:00 PM

Jan 29 2025

clumens closed T726: Fix Sphinx warnings for Python API as Merged by committing rP68d1637b4bdd: Refactor: doc: Get rid of sphinx templates..
Jan 29 2025, 10:14 AM · Pacemaker: Documentation
clumens committed rP68d1637b4bdd: Refactor: doc: Get rid of sphinx templates. (authored by clumens).
Refactor: doc: Get rid of sphinx templates.
Jan 29 2025, 10:14 AM
clumens committed rP4b9870189daa: Refactor: doc: Don't use autosummary in the python documentation. (authored by clumens).
Refactor: doc: Don't use autosummary in the python documentation.
Jan 29 2025, 10:14 AM

Jan 28 2025

clumens edited the content of Pacemaker Release Checklist.
Jan 28 2025, 11:16 AM · Pacemaker

Jan 27 2025

clumens committed rP3fd7845dc1ef: Refactor: cts: Use f-strings in cts regression tests. (authored by clumens).
Refactor: cts: Use f-strings in cts regression tests.
Jan 27 2025, 5:50 PM
clumens committed rP17f314cc1bd5: Refactor: cts: Use f-strings instead of string addition. (authored by clumens).
Refactor: cts: Use f-strings instead of string addition.
Jan 27 2025, 5:50 PM
clumens committed rP2f0f595131df: Refactor: cts: Fix pylint problems in cts-fencing. (authored by clumens).
Refactor: cts: Fix pylint problems in cts-fencing.
Jan 27 2025, 5:50 PM
clumens committed rP96d6ca742458: Refactor: cts: Fix pyflake problems in cts-fencing. (authored by clumens).
Refactor: cts: Fix pyflake problems in cts-fencing.
Jan 27 2025, 5:50 PM
clumens committed rP3e1c6af034c7: Refactor: cts: Clarify spacing in cts-exec.in. (authored by clumens).
Refactor: cts: Clarify spacing in cts-exec.in.
Jan 27 2025, 5:50 PM

Jan 23 2025

clumens changed the status of T945: crm_simulate should exit cleanly if attempting to fail a nonexistent node from Open to WIP.
Jan 23 2025, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
clumens changed the status of T726: Fix Sphinx warnings for Python API from Open to WIP.
Jan 23 2025, 9:54 AM · Pacemaker: Documentation

Jan 15 2025

clumens committed rPcc33c6e4bca7: Refactor: python: Convert to using f-strings in the python module. (authored by clumens).
Refactor: python: Convert to using f-strings in the python module.
Jan 15 2025, 4:22 PM
clumens committed rP9d1bb1430f68: Low: cts: Fix a regression in detailed results reporting. (authored by clumens).
Low: cts: Fix a regression in detailed results reporting.
Jan 15 2025, 4:22 PM

Jan 13 2025

clumens edited the content of TLS certificate setup.
Jan 13 2025, 11:21 AM

Jan 10 2025

clumens edited the content of TLS certificate setup.
Jan 10 2025, 3:21 PM

Jan 3 2025

clumens changed the status of T961: Implement PSK for remote CIB administration and deprecate insecure methods from Open to WIP.
Jan 3 2025, 11:13 AM · Restricted Project, Restricted Project, Restricted Project

Jan 2 2025

clumens added a project to T961: Implement PSK for remote CIB administration and deprecate insecure methods: Restricted Project.

With the recent TLS changes, I think we have all the pieces in place and this should be a simple matter of gluing them together. Most everything in remote CIB admin/Pacemaker Remote gnutls connection management land is pretty well broken into functions now. It might simply be a matter of passing the right cred_type around - it's probably more work to check the environment or command line (or whatever) to decide what connection type it is than it will be to actually implement this.

Jan 2 2025, 3:44 PM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2024

clumens edited the content of TLS certificate setup.
Dec 11 2024, 4:00 PM
clumens committed rP813e25d5134f: Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg. (authored by clumens).
Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg.
Dec 11 2024, 3:10 PM
clumens committed rP4b90fa5e4057: Low: libcrmcommon: Set *tls = NULL in a few more locations. (authored by clumens).
Low: libcrmcommon: Set *tls = NULL in a few more locations.
Dec 11 2024, 3:10 PM
clumens committed rPc3a5fcc11fb3: Feature: daemons: Enable TLS support for Pacemaker Remote nodes. (authored by clumens).
Feature: daemons: Enable TLS support for Pacemaker Remote nodes.
Dec 11 2024, 3:10 PM
clumens committed rP5a548f4cd15c: Feature: liblrmd: Enable TLS support for Pacemaker Remote clients. (authored by clumens).
Feature: liblrmd: Enable TLS support for Pacemaker Remote clients.
Dec 11 2024, 3:10 PM
clumens committed rPa924ccc3a3c4: Doc: sysconfig: Explain permissions needed on TLS-related files. (authored by clumens).
Doc: sysconfig: Explain permissions needed on TLS-related files.
Dec 11 2024, 3:10 PM
clumens committed rP724b9906a52c: Feature: sysconfig: Document using certificates for remote nodes. (authored by clumens).
Feature: sysconfig: Document using certificates for remote nodes.
Dec 11 2024, 3:10 PM
clumens committed rP2f0a0ca7de65: Doc: Pacemaker Explained: Add documentation for TLS options. (authored by clumens).
Doc: Pacemaker Explained: Add documentation for TLS options.
Dec 11 2024, 3:10 PM
clumens committed rPd4c777a904f7: Refactor: libcrmcommon: Only set gnutls priorities when needed. (authored by clumens).
Refactor: libcrmcommon: Only set gnutls priorities when needed.
Dec 11 2024, 3:10 PM
clumens edited the content of TLS certificate setup.
Dec 11 2024, 12:58 PM
clumens edited the content of TLS certificate setup.
Dec 11 2024, 12:54 PM
clumens edited the content of TLS certificate setup.
Dec 11 2024, 12:45 PM
clumens created an object: TLS certificate setup.
Dec 11 2024, 12:35 PM

Dec 10 2024

clumens committed rPcbd069fb5462: Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg. (authored by clumens).
Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg.
Dec 10 2024, 5:54 PM
clumens committed rP57a03bff39ce: Feature: daemons: Enable TLS support for Pacemaker Remote nodes. (authored by clumens).
Feature: daemons: Enable TLS support for Pacemaker Remote nodes.
Dec 10 2024, 5:54 PM
clumens committed rP7add90ffb28e: Low: libcrmcommon: Set *tls = NULL in a few more locations. (authored by clumens).
Low: libcrmcommon: Set *tls = NULL in a few more locations.
Dec 10 2024, 5:54 PM
clumens committed rPab92f64bdf3f: Feature: liblrmd: Enable TLS support for Pacemaker Remote clients. (authored by clumens).
Feature: liblrmd: Enable TLS support for Pacemaker Remote clients.
Dec 10 2024, 5:54 PM
clumens committed rPa36d3087329d: Doc: sysconfig: Explain permissions needed on TLS-related files. (authored by clumens).
Doc: sysconfig: Explain permissions needed on TLS-related files.
Dec 10 2024, 5:54 PM
clumens committed rPfbc2b12a44cc: Feature: sysconfig: Document using certificates for remote nodes. (authored by clumens).
Feature: sysconfig: Document using certificates for remote nodes.
Dec 10 2024, 5:54 PM
clumens committed rPfada80d7b8dc: Doc: Pacemaker Explained: Add documentation for TLS options. (authored by clumens).
Doc: Pacemaker Explained: Add documentation for TLS options.
Dec 10 2024, 5:54 PM
clumens committed rPb15d76b9d544: Refactor: libcrmcommon: Only set gnutls priorities when needed. (authored by clumens).
Refactor: libcrmcommon: Only set gnutls priorities when needed.
Dec 10 2024, 5:54 PM
clumens committed rPfb7a6c4a1ec3: Refactor: libcib: Unindent code in cib_new. (authored by clumens).
Refactor: libcib: Unindent code in cib_new.
Dec 10 2024, 10:44 AM
clumens committed rP71a71004103c: Refactor: libcib: Rearrange cib_remote_signon a bit. (authored by clumens).
Refactor: libcib: Rearrange cib_remote_signon a bit.
Dec 10 2024, 10:44 AM
clumens committed rPb050f0155257: Refactor: libcrmcommon: Use our own logging for gnutls. (authored by clumens).
Refactor: libcrmcommon: Use our own logging for gnutls.
Dec 10 2024, 10:44 AM
clumens committed rP49c4e87cf251: Refactor: libcrmcommon: Move tls priority detection into a function. (authored by clumens).
Refactor: libcrmcommon: Move tls priority detection into a function.
Dec 10 2024, 10:44 AM
clumens committed rP72f51f51b7fd: Refactor: libs: Move tls-specific code from remote.c to tls.c. (authored by clumens).
Refactor: libs: Move tls-specific code from remote.c to tls.c.
Dec 10 2024, 10:44 AM
clumens committed rPb59141d075db: Feature: libcrmcommon: Add pcmk__x509_enabled. (authored by clumens).
Feature: libcrmcommon: Add pcmk__x509_enabled.
Dec 10 2024, 10:44 AM
clumens committed rPc9fc1ddee0f9: Feature: sysconfig: Add env settings needed for X509 authentication. (authored by clumens).
Feature: sysconfig: Add env settings needed for X509 authentication.
Dec 10 2024, 10:44 AM
clumens committed rP5984f0f6d2f7: Refactor: libcrmcommon: Change the type of tls_session... (authored by clumens).
Refactor: libcrmcommon: Change the type of tls_session...
Dec 10 2024, 10:44 AM
clumens committed rP08ddc29b0de1: Refactor: libcrmcommon: pcmk__new_tls_session can take a cert cred type. (authored by clumens).
Refactor: libcrmcommon: pcmk__new_tls_session can take a cert cred type.
Dec 10 2024, 10:44 AM
clumens committed rP8aff17b1a7a3: Refactor: libcrmcommon: Add pcmk__tls_t. (authored by clumens).
Refactor: libcrmcommon: Add pcmk__tls_t.
Dec 10 2024, 10:44 AM