Refactor: python: Disable the similar code warning from pylintrc.
Build: cts: Add cts-cli to the python_files list.
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
Refactor: cts: Remove unnecessary whitespace from the end of commands.
Build: Run cts-cli verbosely.
Test: CTS: Pass verbose argument to the diff function.
API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG.
Med: cts: Add missing crm_simulate regression tests back to cts-cli.
Log: pacemaker-based: improve messages when reading CIB from disk
Log: pacemaker-based: improve exit messages
Log: controller: simplify join finalization messages
Log: pacemaker-based: improve a few messages
Log: controller: drop dot file logs
Log: controller: improve start-up/exit messages
Log: controller: improve resource action execution logs
Build: devel: Add additional cppcheck arguments.
Refactor: libs: Remove existing cppcheck suppressions.
Refactor: daemons: Simplify some code in start_child.
Refactor: libs: Add a couple new cppcheck suppressions.
Build: Fix coverage targets.
clumens changed the status of
T903: Split large IPC messages from
Open to
WIP.
This is going to be very, very difficult to do which is why we've removed it from the RHEL board and lowered the priority. Basically, implements almost all of the API commands for a . All of those would need to be converted over to an async style, and then all of their callers would be. This includes major portions of the control daemon, which isn't very well set up to call the async versions of these functions. It would require rewriting much of liblrmd and the control daemon, and there's simply not enough time to get around to a project of that size.
cppcheck appears to be fine with for me, but I would still be all for investigating removing it in favor of someone else's code.
Build: devel: Replace indent with clang-format.
Refactor: libcrmservice: systemd_init should return a bool.
Refactor: daemons: Fix whitespace problems in execd_commands.c.
Refactor: daemons: Unindent a block of code in action_complete.
Refactor: daemons: Get rid of an unnecessary #endif/#ifdef.
Refactor: daemons: Unindent the goagain block in action_complete.
Low: libcrmservices: Don't leak msg if systemd_proxy is NULL.
Refactor: daemons: Improve whitespace in action_complete.
Refactor: libcrmservices: Unref the dbus connection...
Low: python: Add python value for new CRM_EX_NO_DC exit code.
Refactor: python: Rename variables in Audit __call__ methods.
Refactor: python: Reduce code duplication looking for core dumps.
Low: python: Use coredumpctl to check for core files.
Refactor: cts: _find_core_on_fs can now take a list of locations.
clumens added subtasks for
T970: Decrease code duplication in cts regression tests:
T846: Move cts-cli validity and upgrade tests to cts-schemas,
Unknown Object (Maniphest Task),
Unknown Object (Maniphest Task),
Unknown Object (Maniphest Task).
clumens edited the content of
Patch Review.
clumens edited the content of
Patch Review.
clumens created an object:
Patch Review.
Refactor: doc: Get rid of sphinx templates.
Refactor: doc: Don't use autosummary in the python documentation.
Refactor: cts: Use f-strings in cts regression tests.
Refactor: cts: Use f-strings instead of string addition.
Refactor: cts: Fix pylint problems in cts-fencing.
Refactor: cts: Fix pyflake problems in cts-fencing.
Refactor: cts: Clarify spacing in cts-exec.in.
Refactor: python: Convert to using f-strings in the python module.
Low: cts: Fix a regression in detailed results reporting.
With the recent TLS changes, I think we have all the pieces in place and this should be a simple matter of gluing them together. Most everything in remote CIB admin/Pacemaker Remote gnutls connection management land is pretty well broken into functions now. It might simply be a matter of passing the right around - it's probably more work to check the environment or command line (or whatever) to decide what connection type it is than it will be to actually implement this.
Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg.
Low: libcrmcommon: Set *tls = NULL in a few more locations.
Feature: daemons: Enable TLS support for Pacemaker Remote nodes.
Feature: liblrmd: Enable TLS support for Pacemaker Remote clients.
Doc: sysconfig: Explain permissions needed on TLS-related files.
Feature: sysconfig: Document using certificates for remote nodes.
Doc: Pacemaker Explained: Add documentation for TLS options.
Refactor: libcrmcommon: Only set gnutls priorities when needed.
Refactor: libcrmcommon: pcmk__x509_enabled doesn't need an arg.
Feature: daemons: Enable TLS support for Pacemaker Remote nodes.
Low: libcrmcommon: Set *tls = NULL in a few more locations.
Feature: liblrmd: Enable TLS support for Pacemaker Remote clients.
Doc: sysconfig: Explain permissions needed on TLS-related files.
Feature: sysconfig: Document using certificates for remote nodes.
Doc: Pacemaker Explained: Add documentation for TLS options.
Refactor: libcrmcommon: Only set gnutls priorities when needed.
Refactor: libcib: Unindent code in cib_new.
Refactor: libcib: Rearrange cib_remote_signon a bit.
Refactor: libcrmcommon: Use our own logging for gnutls.
Refactor: libcrmcommon: Move tls priority detection into a function.
Refactor: libs: Move tls-specific code from remote.c to tls.c.
Feature: libcrmcommon: Add pcmk__x509_enabled.
Feature: sysconfig: Add env settings needed for X509 authentication.
Refactor: libcrmcommon: Change the type of tls_session...
Refactor: libcrmcommon: pcmk__new_tls_session can take a cert cred type.
Refactor: libcrmcommon: Add pcmk__tls_t.