Merge pull request #3157 from clumens/unittests

Refactor: cts, python: Move ClusterManager into the _cts module.

Refactor: python: Remove unreachable or commented out code.

Refactor: python, cts: Rename errorstoignore to errors_to_ignore.

Refactor: python: Remove the unused RereadCM and rereadall methods.

Refactor: python: Improve string substitutions in clustermanager.py.

Refactor: python: Minor updates to clustermanager.py.

Refactor: python: is_node_dc should return a boolean.

Refactor: python: HasQuorum should return a boolean.

Refactor: python: Unindent a bunch of code blocks.

Refactor: python: StataCM should return a boolean.

Low: python: Fix a format string error in raising an exception.

Refactor: python: Rename SetStandbyMode to set_standby_mode.

Refactor: python: Disable several pylint warnings in clustermanager.py.

Refactor: python: Simplify list creation.

Refactor: python: Improve conditional tests in clustermanager.py.

Refactor: python: Remove unused variables.

Refactor: python: Improve StartaCM and StartaCMnoBlock.

Refactor: python: Improve StopaCM and StopaCMnoBlock.

Refactor: python: Return a boolean from startall and stopall.

Refactor: python: Use booleans throughout clustermanager.py.

Refactor: python: Rename functions in clustermanager.py.

Refactor: python: Improve Components in clustermanager.py.

Refactor: python: Rename ShouldBeStatus to expected_status.

Refactor: python: Rename Env to env.

Refactor: python: Rename attributes in clustermanager.py.

Refactor: python: Improve a few remaining easy lines.

Refactor: python: Remove key_for_node.

Refactor: python: Improve whitespace in clustermanager.py.

Refactor: python: Update standby mode setting/getting.

Refactor: python: Add docstrings to clustermanager.py.

Merge pull request #3155 from clumens/cts-ClusterManager

Fix: controller: do not check whether watchdog fencing is enabled for the node…

Merge pull request #3154 from gao-yan/not-check-watchdog-fencing

Low: various: compare XML element names case-sensitively

API: libcrmcommon: deprecate TYPE() macro

API: libcrmcommon: deprecate crm_element_name()

API: libcrmcommon: deprecate xml_has_children()

Refactor: based: drop redundant check

Merge pull request #3153 from kgaillot/xml

Merge pull request #404 from kronosnet/stable1-proposed

build: disable fortify check for test binaries

build: autodetect fortify source level automatically

build: annocheck disable cf-protection

Merge pull request #410 from kronosnet/fix-fortify

build: disable fortify check for test binaries

build: autodetect fortify source level automatically

build: annocheck disable cf-protection

Refactor: cts: Remove the unit test portion from CIB.py.

Refactor: python: Remove commented out code in cib.py.

Refactor: python: Un-indent a big block of code.

Refactor: cts, python: Move CIB into the _cts module.

Refactor: python: Simplify list iteration.

Refactor: python: Minor improvements to cib.py.

Refactor: python: Use subsitution strings instead of adding.

Refactor: python: Simplify creating a ConfigFactory instance.

Refactor: python: Remove cluster_monitor from CTS.

Refactor: python: Remove unused variables.

Refactor: python: Remove the ConfigBase class.

Refactor: python: Rename most attributes to be private.

Refactor: python: Improve whitespace in cib.py.

Refactor: python: Disable certain pylint warnings.

Refactor: python: Update docstrings in cibxml.py for new cib name.

Refactor: python: Simplify arguments to functions.

Refactor: python Add docstrings to cib.py.

Feature: build,python: Add a variable for the latest CIB schema version.

Low: python: Default to the latest CIB schema version.

Merge pull request #3150 from clumens/cts-cib

API: libcrmcommon: xml_top argument of xpath_search() is now const

Refactor: libcrmcommon: Use xmlNewChild() in create_xml_node()

Refactor: libcrmcommon: Replace xmlNewNode() with xmlNewDocRawNode()

Refactor: libpe_status: Drop redundant xmlNewChild()

Refactor: libcrmcommon: Drop getDocPtr() from internal code

Refactor: based: Include glib.h and libxml/tree.h expicitly

API: libcrmcommon: Deprecate getDocPtr()

Refactor: based, libcib: Drop cib_operation_t:cleanup

Refactor: libcib: New enum cib__op_type

Refactor: based, libcib: New cib_operation_t:type member

Refactor: libcib: Rename cib_op_t to cib__op_fn_t

Refactor: based, libcib: Drop cib_operation_t:prepare

Refactor: based: Rename based_common.c to based_operation.c

Refactor: based, libcib: Use a single cib_operation_t table

Refactor: based: Remove unnecessary includes from based_operation.c

Refactor: libcib: Rename enum cib_op_attr to cib__op_attr

Refactor: based, libcib: Rename cib_operation_t to cib__operation_t

Refactor: libcrmcommon: Check xml->doc != NULL in top-level functions

Merge pull request #3151 from nrwahl2/nrwahl2-transactions

API: libpe_status,libpe_rules,libcrmcommon: move enum rsc_recovery_type to…

API: libcrmcommon: add pcmk_multiply_active_restart to enum rsc_recovery_type

API: libcrmcommon: deprecate recovery_stop_start in enum rsc_recovery_type

API: libcrmcommon: add pcmk_multiply_active_stop to enum rsc_recovery_type

API: libcrmcommon: add pcmk_multiply_active_block to enum rsc_recovery_type

API: libcrmcommon: deprecate recovery_stop_only in enum rsc_recovery_type

API: libcrmcommon: add pcmk_multiply_active_unexpected to enum rsc_recovery_type

API: libcrmcommon: deprecate recovery_block in enum rsc_recovery_type

API: libcrmcommon: deprecate recovery_stop_unexpected in enum rsc_recovery_type

Merge pull request #3135 from kgaillot/best-practices

Refactor: libpacemaker: Check whether instance already assigned

Refactor: libpe_status: Copy count in pe__copy_node()

Refactor: libpacemaker: Return chosen node from assign_instance()