Page MenuHomeClusterLabs Projects
Feed All Stories

Wed, Mar 5

clumens committed rPe11bf24ce2ff: Refactor: cts: Disable pylint warnings we're not going to address. (authored by clumens).
Refactor: cts: Disable pylint warnings we're not going to address.
Wed, Mar 5, 2:28 PM
clumens committed rP76cf88640ad4: Refactor: cts: Unindent some code where possible. (authored by clumens).
Refactor: cts: Unindent some code where possible.
Wed, Mar 5, 2:28 PM
clumens committed rP9d4dc31cfee9: Refactor: cts: Fix whitespace around lists and operators. (authored by clumens).
Refactor: cts: Fix whitespace around lists and operators.
Wed, Mar 5, 2:28 PM
clumens committed rP9b31620b4048: Refactor: python: Improve whitespace throughout cts-scheduler. (authored by clumens).
Refactor: python: Improve whitespace throughout cts-scheduler.
Wed, Mar 5, 2:28 PM
clumens committed rP672b24af7853: Refactor: cts: Get rid of the DESC variable. (authored by clumens).
Refactor: cts: Get rid of the DESC variable.
Wed, Mar 5, 2:28 PM
clumens committed rP0423b37bcd6c: Refactor: cts: Disable the too-many-locals warning in cts-scheduler. (authored by clumens).
Refactor: cts: Disable the too-many-locals warning in cts-scheduler.
Wed, Mar 5, 2:28 PM
clumens committed rP235f8105a792: Refactor: cts: Add a function to check if a file is missing or empty. (authored by clumens).
Refactor: cts: Add a function to check if a file is missing or empty.
Wed, Mar 5, 2:28 PM
clumens committed rPa83f4b4a7cd2: Refactor: cts: Improve docstrings in cts-scheduler. (authored by clumens).
Refactor: cts: Improve docstrings in cts-scheduler.
Wed, Mar 5, 2:28 PM
clumens committed rPae44688df3d7: Refactor: python: Disable the similar code warning from pylintrc. (authored by clumens).
Refactor: python: Disable the similar code warning from pylintrc.
Wed, Mar 5, 2:28 PM
clumens committed rPe36b4b8bccd8: Build: cts: Add cts-cli to the python_files list. (authored by clumens).
Build: cts: Add cts-cli to the python_files list.
Wed, Mar 5, 2:28 PM
clumens committed rP301e4678e8e0: Refactor: cts: Fix a pyflake whitespace problem in cts-cli. (authored by clumens).
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
Wed, Mar 5, 2:28 PM
clumens committed rPf69c484027a7: Refactor: cts: Replace {shadow} strings in cts-cli where possible. (authored by clumens).
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
Wed, Mar 5, 2:28 PM
clumens committed rP59114640d618: Refactor: cts: Use {cts_cli_data} as an f-string where possible. (authored by clumens).
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
Wed, Mar 5, 2:28 PM
clumens committed rPc21b30b014e0: Refactor: cts: Remove unnecessary whitespace from the end of commands. (authored by clumens).
Refactor: cts: Remove unnecessary whitespace from the end of commands.
Wed, Mar 5, 2:28 PM
GitHub <noreply@github.com> committed rP162b479221b4: Merge pull request #3820 from clumens/final-pylint (authored by nrwahl2).
Merge pull request #3820 from clumens/final-pylint
Wed, Mar 5, 2:28 PM
nrwahl2 committed rPadc79a525fe8: Test: libcrmcommon: Unit-test pcmk__scan_nvpair() (authored by nrwahl2).
Test: libcrmcommon: Unit-test pcmk__scan_nvpair()
Wed, Mar 5, 11:53 AM
nrwahl2 committed rP47674da06307: Refactor: libcrmcommon: Return standard code from pcmk__scan_nvpair() (authored by nrwahl2).
Refactor: libcrmcommon: Return standard code from pcmk__scan_nvpair()
Wed, Mar 5, 11:53 AM
GitHub <noreply@github.com> committed rPd2695c779958: Merge pull request #3834 from nrwahl2/nrwahl2-nvpair (authored by clumens).
Merge pull request #3834 from nrwahl2/nrwahl2-nvpair
Wed, Mar 5, 11:53 AM
nrwahl2 committed rP98cc2319c7ff: Refactor: libcrmcommon: Use g_strsplit() in pcmk__scan_nvpair() (authored by nrwahl2).
Refactor: libcrmcommon: Use g_strsplit() in pcmk__scan_nvpair()
Wed, Mar 5, 11:53 AM
GitHub <noreply@github.com> committed rPebb13541e17c: Merge pull request #3823 from clumens/crm_simulate-tests (authored by nrwahl2).
Merge pull request #3823 from clumens/crm_simulate-tests
Wed, Mar 5, 11:28 AM
clumens committed rP63e78fbf4622: Build: Run cts-cli verbosely. (authored by clumens).
Build: Run cts-cli verbosely.
Wed, Mar 5, 11:28 AM
GitHub <noreply@github.com> committed rP48ede1b77136: Merge pull request #3829 from clumens/cppcheck (authored by clumens).
Merge pull request #3829 from clumens/cppcheck
Wed, Mar 5, 11:28 AM
clumens committed rP50e9864f6899: Test: CTS: Pass verbose argument to the diff function. (authored by clumens).
Test: CTS: Pass verbose argument to the diff function.
Wed, Mar 5, 11:28 AM
clumens committed rPf39e0e2f6f2d: API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG. (authored by clumens).
API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG.
Wed, Mar 5, 11:28 AM
clumens committed rPc1aa2c722e62: Med: cts: Add missing crm_simulate regression tests back to cts-cli. (authored by clumens).
Med: cts: Add missing crm_simulate regression tests back to cts-cli.
Wed, Mar 5, 11:28 AM
clumens committed rP2380d2b99e7a: Log: pacemaker-based: improve messages when reading CIB from disk (authored by kgaillot).
Log: pacemaker-based: improve messages when reading CIB from disk
Wed, Mar 5, 11:28 AM
GitHub <noreply@github.com> committed rPa9afc90c0821: Merge pull request #3825 from clumens/logging (authored by clumens).
Merge pull request #3825 from clumens/logging
Wed, Mar 5, 11:28 AM
clumens committed rPeb1081cf0e37: Log: pacemaker-based: improve exit messages (authored by kgaillot).
Log: pacemaker-based: improve exit messages
Wed, Mar 5, 11:28 AM
clumens committed rP9ca219f2aac8: Log: controller: simplify join finalization messages (authored by kgaillot).
Log: controller: simplify join finalization messages
Wed, Mar 5, 11:28 AM
clumens committed rP7747df0fb7a0: Log: pacemaker-based: improve a few messages (authored by kgaillot).
Log: pacemaker-based: improve a few messages
Wed, Mar 5, 11:28 AM
clumens committed rP8eab0af5ad98: Log: controller: drop dot file logs (authored by kgaillot).
Log: controller: drop dot file logs
Wed, Mar 5, 11:28 AM
clumens committed rP3cbec72bf4a5: Log: controller: improve start-up/exit messages (authored by kgaillot).
Log: controller: improve start-up/exit messages
Wed, Mar 5, 11:28 AM
clumens committed rP97584ad1f289: Log: controller: improve resource action execution logs (authored by kgaillot).
Log: controller: improve resource action execution logs
Wed, Mar 5, 11:28 AM
clumens committed rPc5ee89910c75: Build: devel: Add additional cppcheck arguments. (authored by clumens).
Build: devel: Add additional cppcheck arguments.
Wed, Mar 5, 11:28 AM
clumens committed rPe636645eef86: Refactor: libs: Remove existing cppcheck suppressions. (authored by clumens).
Refactor: libs: Remove existing cppcheck suppressions.
Wed, Mar 5, 11:28 AM
clumens committed rP9a4a52c47bd0: Refactor: daemons: Simplify some code in start_child. (authored by clumens).
Refactor: daemons: Simplify some code in start_child.
Wed, Mar 5, 11:28 AM
clumens committed rPe31c9a8667e7: Refactor: libs: Add a couple new cppcheck suppressions. (authored by clumens).
Refactor: libs: Add a couple new cppcheck suppressions.
Wed, Mar 5, 11:28 AM
clumens committed rP20bc479523c5: Build: Fix coverage targets. (authored by clumens).
Build: Fix coverage targets.
Wed, Mar 5, 11:28 AM
GitHub <noreply@github.com> committed rPbe24948839e3: Merge pull request #3830 from clumens/coverage (authored by clumens).
Merge pull request #3830 from clumens/coverage
Wed, Mar 5, 11:28 AM
GitHub <noreply@github.com> committed rR646a41d15d39: Merge pull request #2024 from oalbrigt/portblock-use-ocf_log (authored by oalbrigt).
Merge pull request #2024 from oalbrigt/portblock-use-ocf_log
Wed, Mar 5, 11:23 AM
oalbrigt committed rR8a3328c07d8e: portblock: use ocf_log() for logging (authored by oalbrigt).
portblock: use ocf_log() for logging
Wed, Mar 5, 11:23 AM
nrwahl2 added a comment to T973: Get rid of "non-option ARGV-elements" blocks from tools.

crm_resource already uses G_OPTION_REMAINING to collect the remaining arguments into an array. Then after parsing all options, it logs those remaining arguments if they're invalid. However, they're valid if we're running a subcommand that uses options.override_params.

Wed, Mar 5, 11:23 AM · Restricted Project, Pacemaker: Tools
wenningerk updated the task description for T975: adhere node-attribute when colocating e.g. promoted role of one clone with promoted role of another.
Wed, Mar 5, 11:23 AM · Pacemaker: Scheduler
nrwahl2 triaged T974: Error-check snprintf() calls as Wishlist priority.
Wed, Mar 5, 11:23 AM · Pacemaker, Restricted Project
wenningerk triaged T975: adhere node-attribute when colocating e.g. promoted role of one clone with promoted role of another as Normal priority.
Wed, Mar 5, 11:23 AM · Pacemaker: Scheduler

Wed, Feb 19

clumens claimed T903: Split large IPC messages.
Wed, Feb 19, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
clumens changed the status of T903: Split large IPC messages from Open to WIP.
Wed, Feb 19, 3:35 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 18

clumens triaged T973: Get rid of "non-option ARGV-elements" blocks from tools as Wishlist priority.
Tue, Feb 18, 3:41 PM · Restricted Project, Pacemaker: Tools
clumens triaged T972: cts-cli shouldn't write to /tmp during package builds as Low priority.
Tue, Feb 18, 1:33 PM · Restricted Project
clumens added a comment to T901: Use asynchronous communication for liblrmd commands with replies.

This is going to be very, very difficult to do which is why we've removed it from the RHEL board and lowered the priority. Basically, lrmd_send_command implements almost all of the API commands for a lrmd_t. All of those would need to be converted over to an async style, and then all of their callers would be. This includes major portions of the control daemon, which isn't very well set up to call the async versions of these functions. It would require rewriting much of liblrmd and the control daemon, and there's simply not enough time to get around to a project of that size.

Tue, Feb 18, 1:24 PM · Restricted Project, Restricted Project
clumens added a comment to T775: Evaluate replacing pcmk__realloc() with GLib functions.

cppcheck appears to be fine with pcmk__realloc for me, but I would still be all for investigating removing it in favor of someone else's code.

Tue, Feb 18, 1:10 PM · Restricted Project, Pacemaker: Libraries
nrwahl2 committed rPf94ad50b06ff: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Tue, Feb 18, 9:19 AM
nrwahl2 committed rPd60b9407f2db: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Tue, Feb 18, 9:19 AM
nrwahl2 committed rPa54c84e9bfb4: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Tue, Feb 18, 9:19 AM
nrwahl2 committed rPe6ed5ff165df: Refactor: libcrmcommon: Avoid unnecessary allocation for sbd paths (authored by nrwahl2).
Refactor: libcrmcommon: Avoid unnecessary allocation for sbd paths
Tue, Feb 18, 9:19 AM
GitHub <noreply@github.com> committed rP1d6dcabd78bd: Merge pull request #3828 from nrwahl2/nrwahl2-sbindir21 (authored by clumens).
Merge pull request #3828 from nrwahl2/nrwahl2-sbindir21
Tue, Feb 18, 9:19 AM
GitHub <noreply@github.com> committed rP64cd85422c19: Merge pull request #3827 from nrwahl2/nrwahl2-sbindir30 (authored by clumens).
Merge pull request #3827 from nrwahl2/nrwahl2-sbindir30
Tue, Feb 18, 9:19 AM
GitHub <noreply@github.com> committed rP3d0ffefd9e1f: Merge pull request #3826 from nrwahl2/nrwahl2-sbindir (authored by clumens).
Merge pull request #3826 from nrwahl2/nrwahl2-sbindir
Tue, Feb 18, 9:19 AM

Mon, Feb 17

clumens committed rPc8ea0e8e32f9: Build: devel: Replace indent with clang-format. (authored by clumens).
Build: devel: Replace indent with clang-format.
Mon, Feb 17, 3:56 PM
GitHub <noreply@github.com> committed rP77a5fca9f11f: Merge pull request #3824 from clumens/clang-format (authored by clumens).
Merge pull request #3824 from clumens/clang-format
Mon, Feb 17, 3:56 PM
GitHub <noreply@github.com> committed rR575dcec0cd97: Update portblock: improve version detection of iptables (authored by abrychcy <abrychcy@users.noreply.github.com>).
Update portblock: improve version detection of iptables
Mon, Feb 17, 8:37 AM
GitHub <noreply@github.com> committed rR90f9f1c43f3b: portblock: fix version detection of iptables (#2022) (authored by oalbrigt).
portblock: fix version detection of iptables (#2022)
Mon, Feb 17, 8:37 AM
GitHub <noreply@github.com> committed rR938867b0c4a7: simplify iptables version string regex (authored by abrychcy <abrychcy@users.noreply.github.com>).
simplify iptables version string regex
Mon, Feb 17, 8:37 AM

Tue, Feb 11

oalbrigt committed rR9bb30d743d04: ocf-shellfuncs: add missing variable in crm_mon_no_validation() (authored by oalbrigt).
ocf-shellfuncs: add missing variable in crm_mon_no_validation()
Tue, Feb 11, 7:52 AM
GitHub <noreply@github.com> committed rR77d8f026e786: Merge pull request #2021 from oalbrigt/ocf-shellfuncs-add-missing-var (authored by oalbrigt).
Merge pull request #2021 from oalbrigt/ocf-shellfuncs-add-missing-var
Tue, Feb 11, 7:52 AM

Mon, Feb 10

gao-yan committed rPe128ae183337: Fix: libcrmcluster: prevent external callers from triggering assertion when… (authored by gao-yan).
Fix: libcrmcluster: prevent external callers from triggering assertion when…
Mon, Feb 10, 2:27 PM
GitHub <noreply@github.com> committed rPaf3642fbf637: Merge pull request #3821 from gao-yan/server_message_type-NULL (authored by clumens).
Merge pull request #3821 from gao-yan/server_message_type-NULL
Mon, Feb 10, 2:27 PM

Feb 7 2025

nrwahl2 committed rPa90267c6533c: Refactor: various: Use uint32_t for group of pcmk_sim_flags internally (authored by nrwahl2).
Refactor: various: Use uint32_t for group of pcmk_sim_flags internally
Feb 7 2025, 6:51 PM
nrwahl2 committed rPff6e7a9b4b47: Refactor: fencer: Set scheduler input, flags, and status explicitly (authored by nrwahl2).
Refactor: fencer: Set scheduler input, flags, and status explicitly
Feb 7 2025, 6:51 PM
nrwahl2 committed rP37f7210e19cb: Refactor: scheduler: Set scheduler input, flags, and status explicitly (authored by nrwahl2).
Refactor: scheduler: Set scheduler input, flags, and status explicitly
Feb 7 2025, 6:51 PM
nrwahl2 committed rP625672d668e6: Fix: tools: Avoid crash in crm_simulate --profile (authored by nrwahl2).
Fix: tools: Avoid crash in crm_simulate --profile
Feb 7 2025, 6:51 PM
nrwahl2 committed rP481b0dd05b6d: Low: libpacemaker: Handle scandir() error in pcmk__profile_dir() (authored by nrwahl2).
Low: libpacemaker: Handle scandir() error in pcmk__profile_dir()
Feb 7 2025, 6:51 PM
nrwahl2 committed rPa1d865533030: Refactor: libpacemaker: Create scheduler object in pcmk__profile_dir() (authored by nrwahl2).
Refactor: libpacemaker: Create scheduler object in pcmk__profile_dir()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP8b9caadbdfe7: Low: libpacemaker: Fix mem leak in pcmk__profile_dir() (authored by nrwahl2).
Low: libpacemaker: Fix mem leak in pcmk__profile_dir()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP64281aeb87a0: Refactor: libpacemaker: Best practices for pcmk__profile_dir() (authored by nrwahl2).
Refactor: libpacemaker: Best practices for pcmk__profile_dir()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP3fca1ba7a201: Low: tools: Fix overflow in crm_simulate --repeat (authored by nrwahl2).
Low: tools: Fix overflow in crm_simulate --repeat
Feb 7 2025, 6:51 PM
nrwahl2 committed rP9f1edd8bacf3: Refactor: libpacemaker: Use scandir() filter in pcmk__profile_dir() (authored by nrwahl2).
Refactor: libpacemaker: Use scandir() filter in pcmk__profile_dir()
Feb 7 2025, 6:51 PM
nrwahl2 committed rPeae8f5b83265: Refactor: libpacemaker: Don't make unnecessary copy for scheduler input (authored by nrwahl2).
Refactor: libpacemaker: Don't make unnecessary copy for scheduler input
Feb 7 2025, 6:51 PM
nrwahl2 committed rP767c55fcc288: Refactor: libpacemaker: Pass NULL input in pcmk__simulate() (authored by nrwahl2).
Refactor: libpacemaker: Pass NULL input in pcmk__simulate()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP27d519f945db: Refactor: libpacemaker: Set input and flags explicitly in pcmk__verify() (authored by nrwahl2).
Refactor: libpacemaker: Set input and flags explicitly in pcmk__verify()
Feb 7 2025, 6:51 PM
nrwahl2 committed rPae63ed5f5dbe: Refactor: tools: Set scheduler flags explicitly in wait_till_stable() (authored by nrwahl2).
Refactor: tools: Set scheduler flags explicitly in wait_till_stable()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP00b82bd3df0e: Refactor: tools: update_dataset() passes nulls to pcmk__schedule_actions (authored by nrwahl2).
Refactor: tools: update_dataset() passes nulls to pcmk__schedule_actions
Feb 7 2025, 6:51 PM
nrwahl2 committed rP4a3f90b56e4f: Refactor: libpacemaker: Drop unused args from pcmk__schedule_actions() (authored by nrwahl2).
Refactor: libpacemaker: Drop unused args from pcmk__schedule_actions()
Feb 7 2025, 6:51 PM
nrwahl2 committed rP5dbc81938ca4: Fix: libpe_status: Make cluster_status() idempotent (authored by nrwahl2).
Fix: libpe_status: Make cluster_status() idempotent
Feb 7 2025, 6:51 PM
nrwahl2 committed rPf2805067f7d7: Refactor: libpacemaker: Unpack status in pcmk__schedule_actions() (authored by nrwahl2).
Refactor: libpacemaker: Unpack status in pcmk__schedule_actions()
Feb 7 2025, 6:51 PM
GitHub <noreply@github.com> committed rPd06c888ba7de: Merge pull request #3810 from nrwahl2/nrwahl2-crm_resource (authored by clumens).
Merge pull request #3810 from nrwahl2/nrwahl2-crm_resource
Feb 7 2025, 6:51 PM
nrwahl2 committed rPb1ac2a57639a: Feature: libpacemaker: Reset scheduler object in pcmk_simulate() (authored by nrwahl2).
Feature: libpacemaker: Reset scheduler object in pcmk_simulate()
Feb 7 2025, 6:51 PM

Feb 6 2025

clumens updated the task description for T970: Decrease code duplication in cts regression tests.
Feb 6 2025, 3:38 PM · Restricted Project
clumens changed the edit policy for T970: Decrease code duplication in cts regression tests.
Feb 6 2025, 3:31 PM · Restricted Project

Feb 5 2025

clumens committed rP02b1a18c1130: Refactor: libcrmservice: systemd_init should return a bool. (authored by clumens).
Refactor: libcrmservice: systemd_init should return a bool.
Feb 5 2025, 3:44 PM
clumens committed rP9138d96d027b: Refactor: daemons: Fix whitespace problems in execd_commands.c. (authored by clumens).
Refactor: daemons: Fix whitespace problems in execd_commands.c.
Feb 5 2025, 3:44 PM
clumens committed rP96e9f97e4926: Refactor: daemons: Unindent a block of code in action_complete. (authored by clumens).
Refactor: daemons: Unindent a block of code in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP9151b51c50b1: Refactor: daemons: Get rid of an unnecessary #endif/#ifdef. (authored by clumens).
Refactor: daemons: Get rid of an unnecessary #endif/#ifdef.
Feb 5 2025, 3:44 PM
clumens committed rP7874bce94ba8: Refactor: daemons: Unindent the goagain block in action_complete. (authored by clumens).
Refactor: daemons: Unindent the goagain block in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP51a93e771656: Low: libcrmservices: Don't leak msg if systemd_proxy is NULL. (authored by clumens).
Low: libcrmservices: Don't leak msg if systemd_proxy is NULL.
Feb 5 2025, 3:44 PM
clumens committed rP96e9bff3ff7b: Refactor: daemons: Improve whitespace in action_complete. (authored by clumens).
Refactor: daemons: Improve whitespace in action_complete.
Feb 5 2025, 3:44 PM
clumens committed rP4a4e721520a7: Refactor: libcrmservices: Unref the dbus connection... (authored by clumens).
Refactor: libcrmservices: Unref the dbus connection...
Feb 5 2025, 3:44 PM
GitHub <noreply@github.com> committed rP88e9ec132580: Merge pull request #3816 from clumens/dbus-systemd-prep (authored by nrwahl2).
Merge pull request #3816 from clumens/dbus-systemd-prep
Feb 5 2025, 3:44 PM
xin liang <xliang@suse.com> committed rP741f09d0404e: Doc: Pacemaker_Development: Use enum controld_join_phase instead of… (authored by xin liang <xliang@suse.com>).
Doc: Pacemaker_Development: Use enum controld_join_phase instead of…
Feb 5 2025, 10:10 AM
GitHub <noreply@github.com> committed rP5efdc9d5d0cb: Merge pull request #3817 from liangxin1300/20250204_sync_with_doc (authored by clumens).
Merge pull request #3817 from liangxin1300/20250204_sync_with_doc
Feb 5 2025, 10:10 AM