Refactor: controller: Better error checks in controld_delete_node_state

Refactor: libcrmcommon: Drop xmlSetTreeDoc() from getDocPtr()

Refactor: controller: Accept user data in controld_update_cib()

Refactor: controller: Simplify DC join ack update step

Fix: controller: Replace node state atomically at DC join ack step

Merge pull request #3127 from nrwahl2/nrwahl2-T186

Refactor: libpe_status: Add pe__rsc_node flag enum

Refactor: libpe_status: pe_node_attribute_calculated() accepts node type

Fix: libpacemaker: Get container attr from assigned node, if any

Test: scheduler: Update outputs for promotion_attr_value() fix

Merge pull request #3132 from nrwahl2/nrwahl2-fixes

Revert "fence_scsi: fail monitor action when it's unable to change state of…

Refactor: scheduler: consolidate scheduler headers

Refactor: scheduler, tools: use boolean types more appropriately

Log: libpacemaker: use "assignment" terminology consistently

Doc: Pacemaker Explained, Pacemaker Development: use assignment terminology…

Log: libpacemaker: avoid "weight" in log messages

Refactor: scheduler: rename pe__show_node_weights()

Refactor: scheduler: use pe__same_node() where appropriate

Refactor: scheduler: improve formatting of header

Refactor: tools: let implicit cast happen

Low: libpacemaker: use "Assignment" instead of "Allocation"

Merge pull request #3126 from kgaillot/best-practices

build: skip annobin fortify test for test suite

Test: cts-cli,cts-scheduler: update expected scores for function rename

Refactor: scheduler: best practices for pcmk__bundle_allocate()

Refactor: scheduler: best practices for pcmk__bundle_create_actions()

Refactor: scheduler: best practices for pcmk__bundle_internal_constraints()

Refactor: scheduler: remove dead code in pcmk__bundle_internal_constraints()

Refactor: scheduler: de-functionize compatible_replica_for_node()

Refactor: scheduler: best practices for compatible_replica()

Refactor: scheduler: best practices for pcmk__bundle_apply_coloc_score()

Refactor: best practices for pcmk__bundle_action_flags()

Refactor: scheduler: best practices for pcmk__bundle_rsc_location()

Refactor: scheduler: best practices for pcmk__bundle_expand()

Refactor: scheduler: best practices for pcmk__bundle_create_probe()

Refactor: scheduler: best practices for pcmk__output_bundle_actions()

Refactor: scheduler: best practices for pcmk__bundle_add_utilization()

Refactor: scheduler: best practices for pcmk__bundle_shutdown_lock()

Refactor: scheduler: rearrange bundle internal constraint creation

Refactor: scheduler: rename variable for clarity

Merge pull request #3123 from kgaillot/best-practices

Refactor: scheduler: use uint32_t for action flags in method

Doc: scheduler: comment why bundled resource is used for some actions

Build: INSTALL: Add libcmocka version dependency

Merge pull request #3124 from nrwahl2/nrwahl2-fixes

Test with higher fortify

Refactor: scheduler: pass colocation to add_colocated_node_scores()

Fix: scheduler: compare anti-colocation dependent negative preferences against…

Test: scheduler: update group-anticolocation test for recent change

Test: scheduler: add more group anti-colocation tests

Merge pull request #3112 from kgaillot/scheduler

Refactor: scheduler: move is_bundle_node() to libpe_status

Refactor: scheduler: use bundle convenience functions

Refactor: scheduler: expose pe__bundle_replica_t internally

Refactor: scheduler: add accessor for a bundle's inner resource

Refactor: scheduler: add iterator function for bundle replicas

Refactor: scheduler: use replica iterator in pcmk__bundle_create_actions()

Refactor: scheduler: use replica iterator in pcmk__bundle_internal_constraints()

Refactor: scheduler: drop redundant arguments from compatible_replica()

Refactor: scheduler: use replica iterator in compatible_replica_for_node()

Refactor: scheduler: use replica iterator in pcmk__bundle_apply_coloc_score()

Refactor: scheduler: use replica iterator in pcmk__bundle_rsc_location()

Refactor: scheduler: use replica iterator in pcmk__bundle_expand()

Refactor: scheduler: use replica iterator in pcmk__output_bundle_actions()

Refactor: scheduler: use replica iterator in pcmk__bundle_create_probe()

Refactor: scheduler: move pcmk__get_rsc_in_container() to libpe_status

Refactor: scheduler: functionize getting bundle's first container

Refactor: scheduler: isolate bundle variant data to lib/pengine/bundle.c

Test: libpe_status: use bundle iterator in native_find_rsc_test.c

Doc: scheduler: improve doxygen blocks for some bundle functions

Log: scheduler: improve a couple of bundle messages

Refactor: scheduler: improve some bundle internal colocation tags

Refactor: scheduler: drop unnecessary casts to void *

Low: scheduler: fix regression introduced by d0e103782f1

Refactor: scheduler: make primary argument to apply_coloc_score() not const

Refactor: scheduler: make bundle argument to pe__foreach_bundle_replica() not…

Merge pull request #3120 from kgaillot/best-practices

Low: cts: Fix list creation in RemoteDriver.

Refactor: cts: Remove the RollingUpgrade test.

Refactor: python, cts: Move MaintenanceMode into the _cts module.

Refactor: python: Improve comments and whitespace in maintenancemode.py.

Refactor: python: Improve maintenancemode.py.

Refactor: python, cts: Move ResourceRecover into the _cts module.

Refactor: python: Improve resourcerecover.py.

Refactor: python: Improve comments and whitespace in resourcerecover.py.

Refactor: python, cts: Move ComponentFail into the _cts module.

Refactor: python: Improve comments and whitespace in componentfail.py.

Refactor: python: Improve comments and whitespace in splitbraintest.py.

Refactor: python: Improve componentfail.py.

Refactor: python, cts: Move SplitBrainTest into the _cts module.

Refactor: python: Improve splitbraintest.py.

Refactor: python: Improve comments and whitespace in reattach.py.

Refactor: python, cts: Move Reattach into the _cts module.

Refactor: python: Improve reattach.py.

Refactor: python, cts: Move SpecialTest1 into the _cts module.

Refactor: python: Improve comments and whitespace in resynccib.py.

Refactor: python: Improve resynccib.py.

Refactor: python, cts: Move NearQuorumPointTest into the _cts module.

Refactor: python: Improve comments and whitespace in nearquorumpointtest.py.