This is part of CLPR#3403
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 1 2024
Apr 1 2024
kgaillot added a project to T802: cibadmin --show-access on live cluster gives incorrect results for ACL-restricted user: Restricted Project.
nrwahl2 triaged T802: cibadmin --show-access on live cluster gives incorrect results for ACL-restricted user as Normal priority.
nrwahl2 changed the status of T801: Try to replace xml.c:utf8_bytes() with GLib UTF-8 functions from Open to WIP.
kgaillot committed rP1bbfacfcf44a: API: libpe_rules: deprecate pe_test_expression() (authored by kgaillot).
API: libpe_rules: deprecate pe_test_expression()
kgaillot committed rP7b0c849b3b9c: Refactor: libpe_rules,libcrmcommon: move single-rule evaluation to libcrmcommon (authored by kgaillot).
Refactor: libpe_rules,libcrmcommon: move single-rule evaluation to libcrmcommon
kgaillot committed rPd3f4f478e464: API: libpe_rules: deprecate pe_test_rule() (authored by kgaillot).
API: libpe_rules: deprecate pe_test_rule()
kgaillot committed rP18f2508921d6: API: libpe_rules: deprecate pe_eval_subexpr() (authored by kgaillot).
API: libpe_rules: deprecate pe_eval_subexpr()
kgaillot committed rP7b16340abc4f: API: libpe_rules: deprecate pe_eval_expr() (authored by kgaillot).
API: libpe_rules: deprecate pe_eval_expr()
kgaillot committed rPd1a804b3f797: Test: libcrmcommon: add unit tests for pcmk__evaluate_condition() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__evaluate_condition()
kgaillot committed rP001230cef02a: Refactor: libpe_rules: drop no-longer-used internal functions (authored by kgaillot).
Refactor: libpe_rules: drop no-longer-used internal functions
kgaillot committed rP3c144c482155: Test: libcrmcommon: add unit tests for pcmk_evaluate_rule() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk_evaluate_rule()
kgaillot committed rP34b12da59695: Refactor: libcrmcommon: make some evaluation functions library-private (authored by kgaillot).
Refactor: libcrmcommon: make some evaluation functions library-private
kgaillot committed rPd25631379835: Refactor: scheduler: drop redundant code in expression evaluation (authored by kgaillot).
Refactor: scheduler: drop redundant code in expression evaluation
kgaillot committed rPdfb0d1f107e6: Refactor: scheduler: best practices for pcmk_evaluate_rule() (authored by kgaillot).
Refactor: scheduler: best practices for pcmk_evaluate_rule()
kgaillot committed rPeed66e1203ba: Refactor: scheduler: best practices for pcmk__evaluate_condition() (authored by kgaillot).
Refactor: scheduler: best practices for pcmk__evaluate_condition()
kgaillot committed rPa068288685f2: Refactor: scheduler: parse boolean operator into an enum (authored by kgaillot).
Refactor: scheduler: parse boolean operator into an enum
kgaillot committed rP24137b1dca26: Refactor: scheduler: use new condition terminology in more places (authored by kgaillot).
Refactor: scheduler: use new condition terminology in more places
GitHub <noreply@github.com> committed rPcd203c203e63: Merge pull request #3405 from kgaillot/best-practices (authored by kgaillot).
Merge pull request #3405 from kgaillot/best-practices
xuezhixin <xuezhixin@uniontech.com> committed rPe3fa9ed3f591: doc: update po file. (authored by xuezhixin <xuezhixin@uniontech.com>).
doc: update po file.
GitHub <noreply@github.com> committed rP39cf7437cace: Merge pull request #3408 from xuezhixin/main (authored by kgaillot).
Merge pull request #3408 from xuezhixin/main
Ferenc Wágner <wferi@debian.org> committed rP6a882fe8c09c: Log: fencer: always format time_t values as long long (authored by Ferenc Wágner <wferi@debian.org>).
Log: fencer: always format time_t values as long long
GitHub <noreply@github.com> committed rP05a3e8f354fb: Merge pull request #3407 from wferi/wferi/time_t (authored by kgaillot).
Merge pull request #3407 from wferi/wferi/time_t
In T800#11838, @nrwahl2 wrote:<define name="non-empty-string"> <data type="string"> <except><value></value></except> </data> </define>It turns out that due to the same normalization you described, any value that consists of only spaces is rejected. Not just empty strings.
Which might be fine for our purposes, but we need to be aware of it.
For this task, we only need a deprecation warning. When we get around to dropping support for master, the code won't have to worry about it at all -- an XSL transform will map master to clone before the code ever sees it.
Mar 29 2024
Mar 29 2024
nrwahl2 updated the task description for T801: Try to replace xml.c:utf8_bytes() with GLib UTF-8 functions.
nrwahl2 updated the task description for T801: Try to replace xml.c:utf8_bytes() with GLib UTF-8 functions.
<define name="non-empty-string"> <data type="string"> <except><value></value></except> </data> </define>
Taking a look at crm_map_element_name...
Mar 28 2024
Mar 28 2024
nrwahl2 committed rPa892513ade5b: Refactor: libcrmcommon: Simplify replace_xml_child() somewhat (authored by nrwahl2).
Refactor: libcrmcommon: Simplify replace_xml_child() somewhat
nrwahl2 committed rP1b580003fa9c: Refactor: libcrmcommon: Further simplify replace_xml_child() (authored by nrwahl2).
Refactor: libcrmcommon: Further simplify replace_xml_child()
nrwahl2 committed rP0e752418930f: Refactor: libcrmcommon: Functionize replacing an XML node (authored by nrwahl2).
Refactor: libcrmcommon: Functionize replacing an XML node
nrwahl2 committed rP1e4236651722: Refactor: libcrmcommon: New pcmk__xe_replace_match() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xe_replace_match()
nrwahl2 committed rPd216b36cf8e2: API: libcrmcommon: Deprecate replace_xml_child() (authored by nrwahl2).
API: libcrmcommon: Deprecate replace_xml_child()
nrwahl2 committed rP2e60f7e0f59a: Refactor: libcrmcommon: New pcmk__xe_delete_match() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xe_delete_match()
nrwahl2 committed rP2e02bf3e7ff0: Refactor: libcrmcommon: Separate XML tree traversal from work (authored by nrwahl2).
Refactor: libcrmcommon: Separate XML tree traversal from work
nrwahl2 committed rP2d0944d11071: Refactor: libcrmcommon: Clean up free_xml_with_position (authored by nrwahl2).
Refactor: libcrmcommon: Clean up free_xml_with_position
nrwahl2 committed rPac10cea4728c: Refactor: libcrmcommon: pcmk__deleted_xml_t:path is now gchar (authored by nrwahl2).
Refactor: libcrmcommon: pcmk__deleted_xml_t:path is now gchar
nrwahl2 committed rPfa6dba83f383: Refactor: libcrmcommon: xml_element_type2str -> xml_element_type_text (authored by nrwahl2).
Refactor: libcrmcommon: xml_element_type2str -> xml_element_type_text
nrwahl2 committed rPb1af058440d9: Refactor: libcrmcommon: New pcmk__xe_update_match() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xe_update_match()
nrwahl2 committed rPcae07266cafb: API: libcrmcommon: Deprecate update_xml_child() (authored by nrwahl2).
API: libcrmcommon: Deprecate update_xml_child()
nrwahl2 committed rPa4a390be60b4: API: libcrmcommon: Deprecate find_xml_children() (authored by nrwahl2).
API: libcrmcommon: Deprecate find_xml_children()
nrwahl2 committed rP575636e918bb: API: libcrmcommon: Deprecate get_xpath_object_relative() (authored by nrwahl2).
API: libcrmcommon: Deprecate get_xpath_object_relative()
nrwahl2 committed rP850364845508: Refactor: libcrmcommon: Drop XML_PARSER_DEBUG constant (authored by nrwahl2).
Refactor: libcrmcommon: Drop XML_PARSER_DEBUG constant
GitHub <noreply@github.com> committed rPd84c84e61c9f: Merge pull request #3397 from nrwahl2/nrwahl2-xml_attrs3 (authored by nrwahl2).
Merge pull request #3397 from nrwahl2/nrwahl2-xml_attrs3
nrwahl2 committed rPcfff4a9a2107: Refactor: cts-cli: Use create_shadow_cib() in access_render test (authored by nrwahl2).
Refactor: cts-cli: Use create_shadow_cib() in access_render test
nrwahl2 committed rPc821aa102f26: Test: cts-cli: Make access_render tests accessible (authored by nrwahl2).
Test: cts-cli: Make access_render tests accessible
nrwahl2 committed rP1bbf0007288a: Fix: cts-cli: Ensure access_render output is the same regardless of user (authored by nrwahl2).
Fix: cts-cli: Ensure access_render output is the same regardless of user
nrwahl2 committed rP67beb3830aed: Test: cts-cli: Update after using create_shadow_cib() (authored by nrwahl2).
Test: cts-cli: Update after using create_shadow_cib()
nrwahl2 committed rPab997368632b: Test: cts-cli: Run access_render by default (authored by nrwahl2).
Test: cts-cli: Run access_render by default
nrwahl2 committed rP75b99394479b: Test: cts-cli: Add write permission in access_render tests (authored by nrwahl2).
Test: cts-cli: Add write permission in access_render tests
nrwahl2 committed rP9b8cf489d42f: Test: cts-cli: Update output for write permission in access_render (authored by nrwahl2).
Test: cts-cli: Update output for write permission in access_render
GitHub <noreply@github.com> committed rPd82a8bb04ee5: Merge pull request #3404 from nrwahl2/nrwahl2-access_render (authored by kgaillot).
Merge pull request #3404 from nrwahl2/nrwahl2-access_render
nrwahl2 committed rP4f9b75383b40: Refactor: libcrmcommon: Don't escape when creating XML (authored by nrwahl2).
Refactor: libcrmcommon: Don't escape when creating XML
nrwahl2 committed rPa791b0f295c7: Fix: libcrmcommon: Escape newlines and tabs in XML attribute values (authored by nrwahl2).
Fix: libcrmcommon: Escape newlines and tabs in XML attribute values
nrwahl2 committed rP781d971396cd: Refactor: libcrmcommon: Capital letters in hex XML character references (authored by nrwahl2).
Refactor: libcrmcommon: Capital letters in hex XML character references
nrwahl2 committed rPd6daa67bfb49: Refactor: libcrmcommon: Sanity-check utf8_bytes() result (authored by nrwahl2).
Refactor: libcrmcommon: Sanity-check utf8_bytes() result
nrwahl2 committed rPacfbd5e01a86: Refactor: libstonithd: Avoid unnecessary allocs in stonith__lha_metadata (authored by nrwahl2).
Refactor: libstonithd: Avoid unnecessary allocs in stonith__lha_metadata
nrwahl2 committed rP99be2e027f96: Refactor: libcrmcommon: Avoid strlen() in pcmk__xml_needs_escape() (authored by nrwahl2).
Refactor: libcrmcommon: Avoid strlen() in pcmk__xml_needs_escape()
nrwahl2 committed rP7b572b9fe7fe: Refactor: libcrmcommon: Drop replace_text() from pcmk__xml_escape() (authored by nrwahl2).
Refactor: libcrmcommon: Drop replace_text() from pcmk__xml_escape()
nrwahl2 committed rPbf22fe296ce8: Refactor: libcrmcommon: New enum pcmk__xml_escape_type (authored by nrwahl2).
Refactor: libcrmcommon: New enum pcmk__xml_escape_type
nrwahl2 committed rP24720364afe5: Refactor: libcrmcommon: New pcmk__xml_escape_attr_pretty enum value (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xml_escape_attr_pretty enum value
nrwahl2 committed rP6ee3a0ad1684: Refactor: libcrmcommon: New helper in pcmk__xml_escape test (authored by nrwahl2).
Refactor: libcrmcommon: New helper in pcmk__xml_escape test
nrwahl2 committed rP9434efe7db8b: Test: libcrmcommon: Add unit tests for pcmk__xml_escape_attr_pretty (authored by nrwahl2).
Test: libcrmcommon: Add unit tests for pcmk__xml_escape_attr_pretty
nrwahl2 closed T799: Escape whitespace in node attribute output in a way that is parseable by OpenStack as Merged by committing rP0fdd73fbbf5f: Fix: libcrmcommon: Escape some chars in XML attribute text output.
Mar 28 2024, 7:00 PM · Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
nrwahl2 committed rP13b467bbccb4: Refactor: libcrmcommon: New PCMK__XML_ENTITY string constants (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__XML_ENTITY string constants
nrwahl2 committed rP0fdd73fbbf5f: Fix: libcrmcommon: Escape some chars in XML attribute text output (authored by nrwahl2).
Fix: libcrmcommon: Escape some chars in XML attribute text output
nrwahl2 committed rPb5d323e57f5a: Doc: Pacemaker Explained: Document whitespace in attribute values (authored by nrwahl2).
Doc: Pacemaker Explained: Document whitespace in attribute values
GitHub <noreply@github.com> committed rP86787fccdd8b: Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape (authored by kgaillot).
Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape
kgaillot committed rP268fa1bbeea2: Refactor: libcrmcommon,libpe_rules: move operation evaluation to libcrmcommon (authored by kgaillot).
Refactor: libcrmcommon,libpe_rules: move operation evaluation to libcrmcommon
kgaillot committed rP3a90ac9cc0cb: Refactor: scheduler: best practices for pcmk__evaluate_op_expression() (authored by kgaillot).
Refactor: scheduler: best practices for pcmk__evaluate_op_expression()
kgaillot committed rP34d1ea4df60e: Test: libcrmcommon: add unit tests for pcmk__evaluate_op_expression() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__evaluate_op_expression()
kgaillot committed rP452516aa991c: Refactor: libcrmcommon,libpe_rules: move resource evaluation to libcrmcommon (authored by kgaillot).
Refactor: libcrmcommon,libpe_rules: move resource evaluation to libcrmcommon
kgaillot committed rP4f12b61aafe1: Refactor: scheduler: best practices for pcmk__evaluate_rsc_expression() (authored by kgaillot).
Refactor: scheduler: best practices for pcmk__evaluate_rsc_expression()
kgaillot committed rP925d93c20bec: Test: libcrmcommon: add unit tests for pcmk__evaluate_rsc_expression() (authored by kgaillot).
Test: libcrmcommon: add unit tests for pcmk__evaluate_rsc_expression()
GitHub <noreply@github.com> committed rP6acac7f2b21d: Merge pull request #3401 from kgaillot/best-practices (authored by kgaillot).
Merge pull request #3401 from kgaillot/best-practices
clumens committed rPc2bd7b769b47: Test: build: Move common test environment stuff into tap.mk. (authored by clumens).
Test: build: Move common test environment stuff into tap.mk.
clumens committed rP68072052c770: Low: tools: Fix the arguments annotation for ticket-constraints. (authored by clumens).
Low: tools: Fix the arguments annotation for ticket-constraints.
clumens committed rP87345f883d17: API: schemas: Change the type of a ticket's id attribute. (authored by clumens).
API: schemas: Change the type of a ticket's id attribute.
clumens committed rPb178b01ca636: Refactor: test: Add CIB-related single unit test teardown code. (authored by clumens).
Refactor: test: Add CIB-related single unit test teardown code.
clumens committed rP3c3ffab1d4b7: Refactor: test: Add CIB-related single unit test setup code. (authored by clumens).
Refactor: test: Add CIB-related single unit test setup code.
clumens committed rP3d21396d702c: Refactor: test: Add CIB-related unit test group setup code. (authored by clumens).
Refactor: test: Add CIB-related unit test group setup code.
clumens committed rPec6d0e8e29d0: Test: libcrmcommon: Exclude unittest.c from test coverage. (authored by clumens).
Test: libcrmcommon: Exclude unittest.c from test coverage.
clumens committed rPc93851fdc948: Refactor: libcrmcommon: Return EINVAL in pcmk__xml_output_new. (authored by clumens).
Refactor: libcrmcommon: Return EINVAL in pcmk__xml_output_new.
clumens committed rPb0147a95c62e: Low: scheduler: Add PCMK__XA_GRANTED to ticket_state XML. (authored by clumens).
Low: scheduler: Add PCMK__XA_GRANTED to ticket_state XML.
clumens committed rP120dcab550a5: Refactor: libcrmcommon: Let pcmk__xml_output_finish take a NULL out. (authored by clumens).
Refactor: libcrmcommon: Let pcmk__xml_output_finish take a NULL out.
clumens committed rPa8ce56cb7d97: Refactor: libpacemaker: Alphabetize output message list. (authored by clumens).
Refactor: libpacemaker: Alphabetize output message list.
clumens committed rP60ae038d0a6a: Refactor: libpacemaker: Expose init_rule_check internally. (authored by clumens).
Refactor: libpacemaker: Expose init_rule_check internally.
clumens committed rP1e4cbf543d60: Refactor: libpacemaker: Add an internal setup function. (authored by clumens).
Refactor: libpacemaker: Add an internal setup function.
GitHub <noreply@github.com> committed rPb3fd453d0839: Merge pull request #3402 from clumens/crm_ticket-prep (authored by kgaillot).
Merge pull request #3402 from clumens/crm_ticket-prep
kgaillot moved T799: Escape whitespace in node attribute output in a way that is parseable by OpenStack from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 28 2024, 10:52 AM · Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot added projects to T799: Escape whitespace in node attribute output in a way that is parseable by OpenStack: Pacemaker (2.1.8), Restricted Project.
Mar 28 2024, 10:51 AM · Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot changed the status of T799: Escape whitespace in node attribute output in a way that is parseable by OpenStack from Open to WIP.
Mar 28 2024, 10:49 AM · Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project