Revisiting this, we should check whether negative stonith-watchdog-timeout is either used by pcs or documented anywhere downstream. If not, just drop the auto-calculation feature and require nonnegative values.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 12 2024
Sep 12 2024
kgaillot added a comment to T749: Validate stonith-watchdog-timeout appropriately and default to 0 on invalid values.
wenningerk added a comment to T749: Validate stonith-watchdog-timeout appropriately and default to 0 on invalid values.
I guess there are more dimension to this problem:
Sep 11 2024
Sep 11 2024
nrwahl2 committed rP262f057f2261: High: libcrmcommon: Include nvpair_compat.h in nvpair.h (authored by nrwahl2).
High: libcrmcommon: Include nvpair_compat.h in nvpair.h
GitHub <noreply@github.com> committed rP0e05565ddffe: Merge pull request #3648 from nrwahl2/nrwahl2-drops (authored by nrwahl2).
Merge pull request #3648 from nrwahl2/nrwahl2-drops
nrwahl2 committed rPe2e9b09a97d4: Feature: various: Drop support for lifetime elements in constraints (authored by nrwahl2).
Feature: various: Drop support for lifetime elements in constraints
GitHub <noreply@github.com> committed rP362427515813: Merge pull request #3647 from nrwahl2/nrwahl2-drops (authored by nrwahl2).
Merge pull request #3647 from nrwahl2/nrwahl2-drops
GitHub <noreply@github.com> committed rPdf09249b6031: Merge pull request #3645 from ClusterLabs/main (authored by kgaillot).
Merge pull request #3645 from ClusterLabs/main
kgaillot moved T875: Disallow node attribute expressions for meta-attributes from Restricted Project Column to Restricted Project Column on the Restricted Project board.
kgaillot triaged T875: Disallow node attribute expressions for meta-attributes as Wishlist priority.
kgaillot updated the task description for T874: Drop support for clone master-max and master-node-max meta-attributes.
kgaillot moved T874: Drop support for clone master-max and master-node-max meta-attributes from Restricted Project Column to Restricted Project Column on the Restricted Project board.
kgaillot changed the status of Restricted Maniphest Task, a subtask of T786: Improve CIB schema, from Open to WIP.
kgaillot triaged T874: Drop support for clone master-max and master-node-max meta-attributes as Wishlist priority.
nrwahl2 committed rP3685e1895d40: Test: cts-schemas: Add tests for dropping lifetime elements (authored by nrwahl2).
Test: cts-schemas: Add tests for dropping lifetime elements
nrwahl2 committed rP6cb97853633c: Low: cts, xml: New upgrade-3.10-3.xsl XSLT stylesheet (authored by nrwahl2).
Low: cts, xml: New upgrade-3.10-3.xsl XSLT stylesheet
nrwahl2 committed rP93406ef758bc: Feature: schemas: Disallow lifetime elements in constraints (authored by nrwahl2).
Feature: schemas: Disallow lifetime elements in constraints
GitHub <noreply@github.com> committed rPc032e26257a1: Merge pull request #3636 from nrwahl2/nrwahl2-xsl_transform4 (authored by nrwahl2).
Merge pull request #3636 from nrwahl2/nrwahl2-xsl_transform4
Sep 10 2024
Sep 10 2024
nrwahl2 committed rP94206f7cc582: Refactor: libcrmcommon: Move XML private magic to lib-private header (authored by nrwahl2).
Refactor: libcrmcommon: Move XML private magic to lib-private header
nrwahl2 committed rP892dfeb983ca: Refactor: various: Use free_xml() instead of xmlFreeNode() (authored by nrwahl2).
Refactor: various: Use free_xml() instead of xmlFreeNode()
nrwahl2 committed rP5af31585adbd: Refactor: libcrmcommon: New pcmk__xml_free_doc() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xml_free_doc()
nrwahl2 committed rPd0f42be68161: Refactor: libcrmcommon: New pcmk__xml_new_doc() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xml_new_doc()
nrwahl2 committed rP74deba6f0ac4: Refactor: various: Limit xmlSetProp() to pcmk__xe_set_attr_force() (authored by nrwahl2).
Refactor: various: Limit xmlSetProp() to pcmk__xe_set_attr_force()
nrwahl2 committed rPc06ff6503b6b: Refactor: libcrmcommon: Add XML test teardown function (authored by nrwahl2).
Refactor: libcrmcommon: Add XML test teardown function
nrwahl2 committed rPd0a539400194: Refactor: libcrmcommon: Avoid xmlUnsetProp() (authored by nrwahl2).
Refactor: libcrmcommon: Avoid xmlUnsetProp()
nrwahl2 committed rP0d3c2fd6cdd5: Refactor: libcrmcommon: remove_xe_attr() -> pcmk__xa_remove() (authored by nrwahl2).
Refactor: libcrmcommon: remove_xe_attr() -> pcmk__xa_remove()
nrwahl2 committed rP86bf474aaa75: Refactor: libcrmcommon: XML best practices in HTML output functions (authored by nrwahl2).
Refactor: libcrmcommon: XML best practices in HTML output functions
nrwahl2 committed rP32576df49829: Low: libcrmcommon: NULL-check pcmk__xml_tree_foreach() argument (authored by nrwahl2).
Low: libcrmcommon: NULL-check pcmk__xml_tree_foreach() argument
nrwahl2 committed rP1811031a00db: Refactor: libcrmcommon: Limit xmlRemoveProp() to pcmk__xa_remove() (authored by nrwahl2).
Refactor: libcrmcommon: Limit xmlRemoveProp() to pcmk__xa_remove()
nrwahl2 committed rPc4f9ad52103f: Refactor: libcrmcommon, libpacemaker: New pcmk__xc_create() (authored by nrwahl2).
Refactor: libcrmcommon, libpacemaker: New pcmk__xc_create()
nrwahl2 committed rP81ae818ea1dc: Test: cts-cli: Improve a couple of replacements (authored by nrwahl2).
Test: cts-cli: Improve a couple of replacements
nrwahl2 committed rP8ee39aeb9ace: Refactor: libcrmcommon: Avoid xmlCopyNode() and xmlDocCopyNode() (authored by nrwahl2).
Refactor: libcrmcommon: Avoid xmlCopyNode() and xmlDocCopyNode()
nrwahl2 committed rP5016f65ca670: Refactor: libcrmcommon: Move pcmk__xc functions to xml_comment.c (authored by nrwahl2).
Refactor: libcrmcommon: Move pcmk__xc functions to xml_comment.c
nrwahl2 committed rP75a2fb122c91: Refactor: libcrmcommon: Improve pcmk__xe_set_content() error checking (authored by nrwahl2).
Refactor: libcrmcommon: Improve pcmk__xe_set_content() error checking
nrwahl2 committed rP46b540d67f39: Fix: libcrmcommon: Drop xmlRegisterNodeDefault() (authored by nrwahl2).
Fix: libcrmcommon: Drop xmlRegisterNodeDefault()
nrwahl2 committed rPd2d50c43d0aa: Refactor: libpacemaker: Limit xmlNewDocRawNode() to pcmk__xe_create() (authored by nrwahl2).
Refactor: libpacemaker: Limit xmlNewDocRawNode() to pcmk__xe_create()
nrwahl2 committed rP446a63afffa7: Doc: libcrmcommon: Update XML unit test setup/teardown comments (authored by nrwahl2).
Doc: libcrmcommon: Update XML unit test setup/teardown comments
nrwahl2 committed rP6227fff7a856: Doc: Pacemaker Development: New XML section (authored by nrwahl2).
Doc: Pacemaker Development: New XML section
nrwahl2 committed rPcd519c833277: Refactor: libcrmcommon: Drop redundant calls to pcmk__xml_mark_created() (authored by nrwahl2).
Refactor: libcrmcommon: Drop redundant calls to pcmk__xml_mark_created()
GitHub <noreply@github.com> committed rP6ec6fb6272e9: Merge pull request #3644 from nrwahl2/nrwahl2-T838 (authored by nrwahl2).
Merge pull request #3644 from nrwahl2/nrwahl2-T838
kgaillot added a parent task for T873: Create tests for schema validation messages: T727: Handle output objects in pcmk_update_configured_schema().
Sep 10 2024, 4:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Sep 10 2024, 4:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Sep 10 2024, 4:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot moved T785: Fix handling of fence device monitor timeouts from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2024, 12:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Sep 10 2024, 11:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot merged T769: Controller should use pcmk_monitor_timeout for recurring monitors when appropriate into T785: Fix handling of fence device monitor timeouts.
Sep 10 2024, 11:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot merged task T769: Controller should use pcmk_monitor_timeout for recurring monitors when appropriate into T785: Fix handling of fence device monitor timeouts.
Sep 10 2024, 11:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kgaillot lowered the priority of T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables from High to Normal.
GitHub <noreply@github.com> committed rRe3ba7ba866d2: podman: Improve handling of "stopping" container removal in remove_container()… (authored by Antonio Romito <antonio.romito@manicom.io>).
podman: Improve handling of "stopping" container removal in remove_container()…
oalbrigt committed rRd66a52cfb25f: Filesystem: dont sleep during stop-action when there are no processes to kill (authored by oalbrigt).
Filesystem: dont sleep during stop-action when there are no processes to kill
oalbrigt committed rRcb6aaffc260e: Filesystem: only use $umount_force after sending kill_signals (authored by oalbrigt).
Filesystem: only use $umount_force after sending kill_signals
GitHub <noreply@github.com> committed rRb2edc99d702c: Merge pull request #1972 from oalbrigt/Filesystem-dont-sleep-no-processes (authored by oalbrigt).
Merge pull request #1972 from oalbrigt/Filesystem-dont-sleep-no-processes
Sep 9 2024
Sep 9 2024
nrwahl2 committed rPc1ea004aa767: Refactor: various: Use pcmk__xml_free() instead of xmlFreeNode() (authored by nrwahl2).
Refactor: various: Use pcmk__xml_free() instead of xmlFreeNode()
nrwahl2 committed rP8eb265b200f4: Refactor: libcrmcommon: New pcmk__xml_new_doc() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xml_new_doc()
nrwahl2 committed rP4c169e1479e3: Refactor: libcrmcommon: Move XML private magic to lib-private header (authored by nrwahl2).
Refactor: libcrmcommon: Move XML private magic to lib-private header
nrwahl2 committed rPffbd9463d126: Refactor: libcrmcommon: Sort XML attributes more efficiently (authored by nrwahl2).
Refactor: libcrmcommon: Sort XML attributes more efficiently
nrwahl2 committed rP4ec57ab1bf87: Refactor: libcrmcommon: New pcmk__xml_free_doc() (authored by nrwahl2).
Refactor: libcrmcommon: New pcmk__xml_free_doc()
nrwahl2 committed rP7ee15576f32a: API: libcrmcommon: Deprecate pcmk_sort_nvpairs() (authored by nrwahl2).
API: libcrmcommon: Deprecate pcmk_sort_nvpairs()
nrwahl2 committed rP417d14a672b7: API: libcrmcommon: Deprecate pcmk_nvpairs2xml_attrs() (authored by nrwahl2).
API: libcrmcommon: Deprecate pcmk_nvpairs2xml_attrs()
nrwahl2 committed rPe8bb4fade8b6: Refactor: various: Limit xmlSetProp() to crm_xml_add() (authored by nrwahl2).
Refactor: various: Limit xmlSetProp() to crm_xml_add()
nrwahl2 committed rPe7f0a1650ff8: API: libcrmcommon: Deprecate pcmk_xml_attrs2nvpairs() (authored by nrwahl2).
API: libcrmcommon: Deprecate pcmk_xml_attrs2nvpairs()
API: libcrmcommon: Deprecate hash2nvpair()
nrwahl2 committed rPc2e0dc7cad42: Refactor: libcrmcommon: XML best practices in HTML output functions (authored by nrwahl2).
Refactor: libcrmcommon: XML best practices in HTML output functions
nrwahl2 committed rP0dffd22c8aed: Refactor: libcrmcommon: remove_xe_attr() -> pcmk__xa_remove() (authored by nrwahl2).
Refactor: libcrmcommon: remove_xe_attr() -> pcmk__xa_remove()
nrwahl2 committed rP699505542c93: Refactor: libcrmcommon: Avoid xmlUnsetProp() (authored by nrwahl2).
Refactor: libcrmcommon: Avoid xmlUnsetProp()
nrwahl2 committed rP4afb2a1641f5: Low: libcrmcommon: NULL-check pcmk__xml_tree_foreach() argument (authored by nrwahl2).
Low: libcrmcommon: NULL-check pcmk__xml_tree_foreach() argument
nrwahl2 committed rP16dc62064872: Refactor: libcrmcommon, libpacemaker: New pcmk__xc_create() (authored by nrwahl2).
Refactor: libcrmcommon, libpacemaker: New pcmk__xc_create()
nrwahl2 committed rP4de04e625466: Refactor: libcrmcommon: Limit xmlRemoveProp() to pcmk__xa_remove() (authored by nrwahl2).
Refactor: libcrmcommon: Limit xmlRemoveProp() to pcmk__xa_remove()
nrwahl2 committed rP17f93f9dbc7a: Refactor: libcrmcommon: Move pcmk__xc functions to xml_comment.c (authored by nrwahl2).
Refactor: libcrmcommon: Move pcmk__xc functions to xml_comment.c
nrwahl2 committed rPf357ff1ed5d9: Refactor: libcrmcommon: Avoid xmlCopyNode() and xmlDocCopyNode() (authored by nrwahl2).
Refactor: libcrmcommon: Avoid xmlCopyNode() and xmlDocCopyNode()
nrwahl2 committed rP942c760b06f7: Test: cts-cli: Improve a couple of replacements (authored by nrwahl2).
Test: cts-cli: Improve a couple of replacements
nrwahl2 closed T838: Manage libxml2 private data better, a subtask of T840: Improve Pacemaker API initialization, as Merged.
nrwahl2 committed rP2d25cfe87e3b: Refactor: libcrmcommon: Improve pcmk__xe_set_content() error checking (authored by nrwahl2).
Refactor: libcrmcommon: Improve pcmk__xe_set_content() error checking
nrwahl2 committed rP656442638ed2: Refactor: libpacemaker: Limit xmlNewDocRawNode() to pcmk__xe_create() (authored by nrwahl2).
Refactor: libpacemaker: Limit xmlNewDocRawNode() to pcmk__xe_create()
nrwahl2 committed rP71609a7db80b: Fix: libcrmcommon: Drop xmlRegisterNodeDefault() (authored by nrwahl2).
Fix: libcrmcommon: Drop xmlRegisterNodeDefault()
nrwahl2 closed T838: Manage libxml2 private data better as Merged by committing rP71609a7db80b: Fix: libcrmcommon: Drop xmlRegisterNodeDefault().
nrwahl2 committed rP8995a2dcf2b9: Doc: libcrmcommon: Update XML unit test setup/teardown comments (authored by nrwahl2).
Doc: libcrmcommon: Update XML unit test setup/teardown comments
nrwahl2 committed rP99f8ee6d2802: Refactor: libcrmcommon: Drop redundant calls to pcmk__xml_mark_created() (authored by nrwahl2).
Refactor: libcrmcommon: Drop redundant calls to pcmk__xml_mark_created()
nrwahl2 committed rP5e196b7be165: Doc: Pacemaker Development: New XML section (authored by nrwahl2).
Doc: Pacemaker Development: New XML section
GitHub <noreply@github.com> committed rPd9af6917a263: Merge pull request #3642 from nrwahl2/nrwahl2-T838 (authored by kgaillot).
Merge pull request #3642 from nrwahl2/nrwahl2-T838
kgaillot added a project to T811: Change base image used in wiki bundle walk-through: Restricted Project.
The XML attribute getters/setters in nvpair.c should move to the new file as well. If the file is ridiculously large, they could alternatively move to xml_attr.c (currently limited to functions that take an xmlAttr argument, but we could relax that since it's negligible).
Sep 9 2024, 11:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Sep 5 2024
Sep 5 2024
kgaillot committed rP92dd1f0ac232: Low: libcrmcommon: use uint32_t in parse_date() (authored by kgaillot).
Low: libcrmcommon: use uint32_t in parse_date()
kgaillot committed rP2e5470541473: Low: libcib: improve error handling in cib_file_new() (authored by kgaillot).
Low: libcib: improve error handling in cib_file_new()
kgaillot committed rP231d89a11828: Refactor: libcrmcommon: validate year in crm_time_days_in_month() (authored by kgaillot).
Refactor: libcrmcommon: validate year in crm_time_days_in_month()
kgaillot committed rP691b84d4b432: Low: libcrmcommon: tweak parse_date() validations (authored by kgaillot).
Low: libcrmcommon: tweak parse_date() validations
kgaillot committed rPd532653b36f6: Low: libcrmcommon: bounds-check seconds in pcmk_parse_interval_spec() (authored by kgaillot).
Low: libcrmcommon: bounds-check seconds in pcmk_parse_interval_spec()
kgaillot committed rPc3d089f20a1f: Low: libcrmcommon: return int from get_ordinal_days() (authored by kgaillot).
Low: libcrmcommon: return int from get_ordinal_days()
GitHub <noreply@github.com> committed rPed381f50edef: Merge pull request #3641 from kgaillot/backport (authored by kgaillot).
Merge pull request #3641 from kgaillot/backport
clumens committed rPe00e9ea51f03: Refactor: cts: Remove an unnecessary newline in cts-exec.in. (authored by clumens).
Refactor: cts: Remove an unnecessary newline in cts-exec.in.
clumens committed rP70ba464232a7: Refactor: cts: Fix pyflake problems in cts-lab.in. (authored by clumens).
Refactor: cts: Fix pyflake problems in cts-lab.in.
clumens committed rPb440bf558b70: Refactor: python: Disable a pylint warning in buildoptions.py. (authored by clumens).
Refactor: python: Disable a pylint warning in buildoptions.py.
GitHub <noreply@github.com> committed rP5ffaece006ad: Merge pull request #3639 from clumens/minor-fixes (authored by kgaillot).
Merge pull request #3639 from clumens/minor-fixes
kgaillot committed rPd6e66cd85f31: API: libcrmcommon: add enum pcmk_ra_caps value pcmk_ra_cap_cli_exec (authored by kgaillot).
API: libcrmcommon: add enum pcmk_ra_caps value pcmk_ra_cap_cli_exec
kgaillot committed rP5cbf2152105c: Build: configure: allow disabling LSB resources (authored by kgaillot).
Build: configure: allow disabling LSB resources
kgaillot committed rP8174ee95f8ea: Build: configure: auto-detect support for service alias (authored by kgaillot).
Build: configure: auto-detect support for service alias
kgaillot committed rP62d5685e98d7: Doc: Pacemaker Explained: clarify resource standard support (authored by kgaillot).
Doc: Pacemaker Explained: clarify resource standard support
GitHub <noreply@github.com> committed rP959e8032f4db: Merge pull request #3640 from kgaillot/backport (authored by kgaillot).
Merge pull request #3640 from kgaillot/backport