Refactor: libcrmcommon: Simplify read_local_file()
Refactor: libpacemaker: Filter out non-regular profile files
Refactor: based, build: Drop struct dirent:d_type check
Merge pull request #3831 from nrwahl2/nrwahl2-refactors
Refactor: libcrmservice: New services__copy_result() function
Refactor: libcrmservice: Store systemd job path in svc_action_private_t
Refactor: libcrmservice: Subscribe to systemd D-Bus signals
Fix: various: Correctly detect completion of systemd start/stop actions
Merge pull request #3818 from nrwahl2/nrwahl2-dbus-systemd
Refactor: libcrmservice: Improve error checks in systemd_service_name()
Refactor: libcrmservice: Fail systemd rsc start if create override fails
Refactor: libcrmservice: Defunctionize create_world_readable()
Refactor: libcrmservice: Avoid gboolean/gchar in systemd_unit_exists()
Refactor: libcrmservice: Check for empty arg in invoke_unit_by_name()
Refactor: libcrmservice: Simplify systemd override path getters
Refactor: libcrmcommon: Drop check for unused flag from str_any_of()
Low: libcrmservice: Fix overrides for systemd resources
Refactor: tools: NULL-check args in cli_resource_print()
Refactor: tools: NULL-check scheduler arg of cli_resource_move()
Refactor: tools: NULL-check scheduler arg in cli_resource_fail()
Refactor: tools: NULL-check scheduler arg of cli_cleanup_all()
Doc: tools: Suppress Coverity false positives in crm_resource.c
Merge pull request #3832 from nrwahl2/nrwahl2-systemd
Doc: libcrmservice: Suppress Coverity false positives
Refactor: Unindent various code blocks in transport.c.
Refactor: Remove global booth_conf variable in transport.c.
Refactor: Add braces around conditional blocks in transport.c.
Refactor: Remove some (void) casts from transport.c.
Refactor: Check the return value of setsockopt.
Refactor: Use whitespace more consistently in transport.c.
Merge pull request #155 from clumens/transport-finish
Refactor: cts: Give an explicit encoding to uses of io.open.
Refactor: cts: Fix the last few pyflake problems in cts-regression.
Refactor: cts: Add the usual pylint import and name pragmas.
Refactor: cts: Don't inherit from object.
Refactor: python: Use += in cts-scheduler for increment.
Refactor: cts: Condense test descriptions onto single lines.
Refactor: cts: Use f-strings in cts-scheduler.
Refactor: python: Don't explicitly compare against an empty list.
Refactor: cts: Disable pylint warnings we're not going to address.
Refactor: cts: Unindent some code where possible.
Refactor: cts: Fix whitespace around lists and operators.
Refactor: python: Improve whitespace throughout cts-scheduler.
Refactor: cts: Get rid of the DESC variable.
Refactor: cts: Disable the too-many-locals warning in cts-scheduler.
Refactor: cts: Add a function to check if a file is missing or empty.
Refactor: cts: Improve docstrings in cts-scheduler.
Refactor: python: Disable the similar code warning from pylintrc.
Build: cts: Add cts-cli to the python_files list.
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
Refactor: cts: Remove unnecessary whitespace from the end of commands.
Merge pull request #3820 from clumens/final-pylint
Test: libcrmcommon: Unit-test pcmk__scan_nvpair()
Refactor: libcrmcommon: Return standard code from pcmk__scan_nvpair()
Merge pull request #3834 from nrwahl2/nrwahl2-nvpair
Refactor: libcrmcommon: Use g_strsplit() in pcmk__scan_nvpair()
Merge pull request #3823 from clumens/crm_simulate-tests
Build: Run cts-cli verbosely.
Merge pull request #3829 from clumens/cppcheck
Test: CTS: Pass verbose argument to the diff function.
API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG.
Med: cts: Add missing crm_simulate regression tests back to cts-cli.
Log: pacemaker-based: improve messages when reading CIB from disk
Merge pull request #3825 from clumens/logging
Log: pacemaker-based: improve exit messages
Log: controller: simplify join finalization messages
Log: pacemaker-based: improve a few messages
Log: controller: drop dot file logs
Log: controller: improve start-up/exit messages
Log: controller: improve resource action execution logs
Build: devel: Add additional cppcheck arguments.
Refactor: libs: Remove existing cppcheck suppressions.
Refactor: daemons: Simplify some code in start_child.
Refactor: libs: Add a couple new cppcheck suppressions.
Build: Fix coverage targets.
Merge pull request #3830 from clumens/coverage
Merge pull request #2024 from oalbrigt/portblock-use-ocf_log
portblock: use ocf_log() for logging
already uses to collect the remaining arguments into an array. Then after parsing all options, it logs those remaining arguments if they're invalid. However, they're valid if we're running a subcommand that uses .
clumens changed the status of
T903: Split large IPC messages from
Open to
WIP.
This is going to be very, very difficult to do which is why we've removed it from the RHEL board and lowered the priority. Basically, implements almost all of the API commands for a . All of those would need to be converted over to an async style, and then all of their callers would be. This includes major portions of the control daemon, which isn't very well set up to call the async versions of these functions. It would require rewriting much of liblrmd and the control daemon, and there's simply not enough time to get around to a project of that size.
cppcheck appears to be fine with for me, but I would still be all for investigating removing it in favor of someone else's code.
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Refactor: libcrmcommon: Avoid unnecessary allocation for sbd paths
Merge pull request #3828 from nrwahl2/nrwahl2-sbindir21
Merge pull request #3827 from nrwahl2/nrwahl2-sbindir30