Page MenuHomeClusterLabs Projects
Feed All Stories

Mar 10 2025

nrwahl2 committed rPe49ec15335bc: Refactor: libcrmcommon: Simplify read_local_file() (authored by nrwahl2).
Refactor: libcrmcommon: Simplify read_local_file()
Mar 10 2025, 11:01 AM
nrwahl2 committed rP468bc50fd4d9: Refactor: libpacemaker: Filter out non-regular profile files (authored by nrwahl2).
Refactor: libpacemaker: Filter out non-regular profile files
Mar 10 2025, 11:01 AM
nrwahl2 committed rP52af7e6ed0b6: Refactor: based, build: Drop struct dirent:d_type check (authored by nrwahl2).
Refactor: based, build: Drop struct dirent:d_type check
Mar 10 2025, 11:01 AM
GitHub <noreply@github.com> committed rP0ab5c4d8f5dc: Merge pull request #3831 from nrwahl2/nrwahl2-refactors (authored by clumens).
Merge pull request #3831 from nrwahl2/nrwahl2-refactors
Mar 10 2025, 11:01 AM

Mar 9 2025

nrwahl2 changed the status of T977: Replace versionsort() with something portable from Open to WIP.
Mar 9 2025, 1:07 AM · Restricted Project, Restricted Project
nrwahl2 triaged T977: Replace versionsort() with something portable as High priority.
Mar 9 2025, 12:10 AM · Restricted Project, Restricted Project

Mar 7 2025

nrwahl2 committed rP4cd3841567d5: Refactor: libcrmservice: New services__copy_result() function (authored by nrwahl2).
Refactor: libcrmservice: New services__copy_result() function
Mar 7 2025, 3:32 PM
nrwahl2 committed rPe61ce9408dc2: Refactor: libcrmservice: Store systemd job path in svc_action_private_t (authored by nrwahl2).
Refactor: libcrmservice: Store systemd job path in svc_action_private_t
Mar 7 2025, 3:32 PM
nrwahl2 committed rPf7bc366299e8: Refactor: libcrmservice: Subscribe to systemd D-Bus signals (authored by clumens).
Refactor: libcrmservice: Subscribe to systemd D-Bus signals
Mar 7 2025, 3:32 PM
nrwahl2 committed rP6e70bb67c2ce: Fix: various: Correctly detect completion of systemd start/stop actions (authored by clumens).
Fix: various: Correctly detect completion of systemd start/stop actions
Mar 7 2025, 3:32 PM
GitHub <noreply@github.com> committed rPecdc3270630a: Merge pull request #3818 from nrwahl2/nrwahl2-dbus-systemd (authored by nrwahl2).
Merge pull request #3818 from nrwahl2/nrwahl2-dbus-systemd
Mar 7 2025, 3:32 PM

Mar 6 2025

nrwahl2 committed rP1ee15f9f6b75: Refactor: libcrmservice: Improve error checks in systemd_service_name() (authored by nrwahl2).
Refactor: libcrmservice: Improve error checks in systemd_service_name()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPa6647c9694ab: Refactor: libcrmservice: Fail systemd rsc start if create override fails (authored by nrwahl2).
Refactor: libcrmservice: Fail systemd rsc start if create override fails
Mar 6 2025, 10:36 AM
nrwahl2 committed rP1c917cb9720d: Refactor: libcrmservice: Defunctionize create_world_readable() (authored by nrwahl2).
Refactor: libcrmservice: Defunctionize create_world_readable()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPb4cf2c2a195f: Refactor: libcrmservice: Avoid gboolean/gchar in systemd_unit_exists() (authored by nrwahl2).
Refactor: libcrmservice: Avoid gboolean/gchar in systemd_unit_exists()
Mar 6 2025, 10:36 AM
nrwahl2 committed rP9f35325b0322: Refactor: libcrmservice: Check for empty arg in invoke_unit_by_name() (authored by nrwahl2).
Refactor: libcrmservice: Check for empty arg in invoke_unit_by_name()
Mar 6 2025, 10:36 AM
nrwahl2 committed rP38a6f527ab8e: Refactor: libcrmservice: Simplify systemd override path getters (authored by nrwahl2).
Refactor: libcrmservice: Simplify systemd override path getters
Mar 6 2025, 10:36 AM
nrwahl2 committed rP23584c1a359d: Refactor: libcrmcommon: Drop check for unused flag from str_any_of() (authored by nrwahl2).
Refactor: libcrmcommon: Drop check for unused flag from str_any_of()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPa74123bd8e53: Low: libcrmservice: Fix overrides for systemd resources (authored by nrwahl2).
Low: libcrmservice: Fix overrides for systemd resources
Mar 6 2025, 10:36 AM
nrwahl2 committed rP98d9c8ac9b4e: Refactor: tools: NULL-check args in cli_resource_print() (authored by nrwahl2).
Refactor: tools: NULL-check args in cli_resource_print()
Mar 6 2025, 10:36 AM
nrwahl2 committed rP5d0bd9fbcb52: Refactor: tools: NULL-check scheduler arg of cli_resource_move() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg of cli_resource_move()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPe596ecc8749a: Refactor: tools: NULL-check scheduler arg in cli_resource_fail() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg in cli_resource_fail()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPaf18549315ad: Refactor: tools: NULL-check scheduler arg of cli_cleanup_all() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg of cli_cleanup_all()
Mar 6 2025, 10:36 AM
nrwahl2 committed rPaca863a713dc: Doc: tools: Suppress Coverity false positives in crm_resource.c (authored by nrwahl2).
Doc: tools: Suppress Coverity false positives in crm_resource.c
Mar 6 2025, 10:36 AM
GitHub <noreply@github.com> committed rP47fa0d8853c9: Merge pull request #3832 from nrwahl2/nrwahl2-systemd (authored by clumens).
Merge pull request #3832 from nrwahl2/nrwahl2-systemd
Mar 6 2025, 10:35 AM
nrwahl2 committed rPbf3ae3312302: Doc: libcrmservice: Suppress Coverity false positives (authored by nrwahl2).
Doc: libcrmservice: Suppress Coverity false positives
Mar 6 2025, 10:35 AM

Mar 5 2025

clumens committed rBfd679976bb8f: Refactor: Unindent various code blocks in transport.c. (authored by clumens).
Refactor: Unindent various code blocks in transport.c.
Mar 5 2025, 5:23 PM
clumens committed rB05c261e6fcd5: Refactor: Remove global booth_conf variable in transport.c. (authored by clumens).
Refactor: Remove global booth_conf variable in transport.c.
Mar 5 2025, 5:23 PM
clumens committed rB6b6d0ba26107: Refactor: Add braces around conditional blocks in transport.c. (authored by clumens).
Refactor: Add braces around conditional blocks in transport.c.
Mar 5 2025, 5:23 PM
clumens committed rB8bfffbd9f836: Refactor: Remove some (void) casts from transport.c. (authored by clumens).
Refactor: Remove some (void) casts from transport.c.
Mar 5 2025, 5:23 PM
clumens committed rB36765017e94a: Refactor: Check the return value of setsockopt. (authored by clumens).
Refactor: Check the return value of setsockopt.
Mar 5 2025, 5:23 PM
clumens committed rB8842fb9dc7f5: Refactor: Use whitespace more consistently in transport.c. (authored by clumens).
Refactor: Use whitespace more consistently in transport.c.
Mar 5 2025, 5:23 PM
GitHub <noreply@github.com> committed rB9391e6a31e27: Merge pull request #155 from clumens/transport-finish (authored by clumens).
Merge pull request #155 from clumens/transport-finish
Mar 5 2025, 5:23 PM
nrwahl2 updated the task description for T976: Replace Pacemaker timers with systemd timers for systemd resource start/stop actions.
Mar 5 2025, 3:08 PM · Restricted Project
nrwahl2 triaged T976: Replace Pacemaker timers with systemd timers for systemd resource start/stop actions as Wishlist priority.
Mar 5 2025, 3:08 PM · Restricted Project
clumens committed rP3dba2c1b2a5e: Refactor: cts: Give an explicit encoding to uses of io.open. (authored by clumens).
Refactor: cts: Give an explicit encoding to uses of io.open.
Mar 5 2025, 2:28 PM
clumens committed rP2f806d08c255: Refactor: cts: Fix the last few pyflake problems in cts-regression. (authored by clumens).
Refactor: cts: Fix the last few pyflake problems in cts-regression.
Mar 5 2025, 2:28 PM
clumens committed rPccb49570cc01: Refactor: cts: Add the usual pylint import and name pragmas. (authored by clumens).
Refactor: cts: Add the usual pylint import and name pragmas.
Mar 5 2025, 2:28 PM
clumens committed rPf830591b354d: Refactor: cts: Don't inherit from object. (authored by clumens).
Refactor: cts: Don't inherit from object.
Mar 5 2025, 2:28 PM
clumens committed rPd268d9eadd8a: Refactor: python: Use += in cts-scheduler for increment. (authored by clumens).
Refactor: python: Use += in cts-scheduler for increment.
Mar 5 2025, 2:28 PM
clumens committed rPbc74c8468bf9: Refactor: cts: Condense test descriptions onto single lines. (authored by clumens).
Refactor: cts: Condense test descriptions onto single lines.
Mar 5 2025, 2:28 PM
clumens committed rP98c49d9b16ee: Refactor: cts: Use f-strings in cts-scheduler. (authored by clumens).
Refactor: cts: Use f-strings in cts-scheduler.
Mar 5 2025, 2:28 PM
clumens committed rP5adaf6e041d8: Refactor: python: Don't explicitly compare against an empty list. (authored by clumens).
Refactor: python: Don't explicitly compare against an empty list.
Mar 5 2025, 2:28 PM
clumens committed rPe11bf24ce2ff: Refactor: cts: Disable pylint warnings we're not going to address. (authored by clumens).
Refactor: cts: Disable pylint warnings we're not going to address.
Mar 5 2025, 2:28 PM
clumens committed rP76cf88640ad4: Refactor: cts: Unindent some code where possible. (authored by clumens).
Refactor: cts: Unindent some code where possible.
Mar 5 2025, 2:28 PM
clumens committed rP9d4dc31cfee9: Refactor: cts: Fix whitespace around lists and operators. (authored by clumens).
Refactor: cts: Fix whitespace around lists and operators.
Mar 5 2025, 2:28 PM
clumens committed rP9b31620b4048: Refactor: python: Improve whitespace throughout cts-scheduler. (authored by clumens).
Refactor: python: Improve whitespace throughout cts-scheduler.
Mar 5 2025, 2:28 PM
clumens committed rP672b24af7853: Refactor: cts: Get rid of the DESC variable. (authored by clumens).
Refactor: cts: Get rid of the DESC variable.
Mar 5 2025, 2:28 PM
clumens committed rP0423b37bcd6c: Refactor: cts: Disable the too-many-locals warning in cts-scheduler. (authored by clumens).
Refactor: cts: Disable the too-many-locals warning in cts-scheduler.
Mar 5 2025, 2:28 PM
clumens committed rP235f8105a792: Refactor: cts: Add a function to check if a file is missing or empty. (authored by clumens).
Refactor: cts: Add a function to check if a file is missing or empty.
Mar 5 2025, 2:28 PM
clumens committed rPa83f4b4a7cd2: Refactor: cts: Improve docstrings in cts-scheduler. (authored by clumens).
Refactor: cts: Improve docstrings in cts-scheduler.
Mar 5 2025, 2:28 PM
clumens committed rPae44688df3d7: Refactor: python: Disable the similar code warning from pylintrc. (authored by clumens).
Refactor: python: Disable the similar code warning from pylintrc.
Mar 5 2025, 2:28 PM
clumens committed rPe36b4b8bccd8: Build: cts: Add cts-cli to the python_files list. (authored by clumens).
Build: cts: Add cts-cli to the python_files list.
Mar 5 2025, 2:28 PM
clumens committed rP301e4678e8e0: Refactor: cts: Fix a pyflake whitespace problem in cts-cli. (authored by clumens).
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
Mar 5 2025, 2:28 PM
clumens committed rPf69c484027a7: Refactor: cts: Replace {shadow} strings in cts-cli where possible. (authored by clumens).
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
Mar 5 2025, 2:28 PM
clumens committed rP59114640d618: Refactor: cts: Use {cts_cli_data} as an f-string where possible. (authored by clumens).
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
Mar 5 2025, 2:28 PM
clumens committed rPc21b30b014e0: Refactor: cts: Remove unnecessary whitespace from the end of commands. (authored by clumens).
Refactor: cts: Remove unnecessary whitespace from the end of commands.
Mar 5 2025, 2:28 PM
GitHub <noreply@github.com> committed rP162b479221b4: Merge pull request #3820 from clumens/final-pylint (authored by nrwahl2).
Merge pull request #3820 from clumens/final-pylint
Mar 5 2025, 2:28 PM
nrwahl2 committed rPadc79a525fe8: Test: libcrmcommon: Unit-test pcmk__scan_nvpair() (authored by nrwahl2).
Test: libcrmcommon: Unit-test pcmk__scan_nvpair()
Mar 5 2025, 11:53 AM
nrwahl2 committed rP47674da06307: Refactor: libcrmcommon: Return standard code from pcmk__scan_nvpair() (authored by nrwahl2).
Refactor: libcrmcommon: Return standard code from pcmk__scan_nvpair()
Mar 5 2025, 11:53 AM
GitHub <noreply@github.com> committed rPd2695c779958: Merge pull request #3834 from nrwahl2/nrwahl2-nvpair (authored by clumens).
Merge pull request #3834 from nrwahl2/nrwahl2-nvpair
Mar 5 2025, 11:53 AM
nrwahl2 committed rP98cc2319c7ff: Refactor: libcrmcommon: Use g_strsplit() in pcmk__scan_nvpair() (authored by nrwahl2).
Refactor: libcrmcommon: Use g_strsplit() in pcmk__scan_nvpair()
Mar 5 2025, 11:53 AM
GitHub <noreply@github.com> committed rPebb13541e17c: Merge pull request #3823 from clumens/crm_simulate-tests (authored by nrwahl2).
Merge pull request #3823 from clumens/crm_simulate-tests
Mar 5 2025, 11:28 AM
clumens committed rP63e78fbf4622: Build: Run cts-cli verbosely. (authored by clumens).
Build: Run cts-cli verbosely.
Mar 5 2025, 11:28 AM
GitHub <noreply@github.com> committed rP48ede1b77136: Merge pull request #3829 from clumens/cppcheck (authored by clumens).
Merge pull request #3829 from clumens/cppcheck
Mar 5 2025, 11:28 AM
clumens committed rP50e9864f6899: Test: CTS: Pass verbose argument to the diff function. (authored by clumens).
Test: CTS: Pass verbose argument to the diff function.
Mar 5 2025, 11:28 AM
clumens committed rPf39e0e2f6f2d: API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG. (authored by clumens).
API: libcrmcommon: Map pcmk_rc_cib_corrupt to CRM_EX_CONFIG.
Mar 5 2025, 11:28 AM
clumens committed rPc1aa2c722e62: Med: cts: Add missing crm_simulate regression tests back to cts-cli. (authored by clumens).
Med: cts: Add missing crm_simulate regression tests back to cts-cli.
Mar 5 2025, 11:28 AM
clumens committed rP2380d2b99e7a: Log: pacemaker-based: improve messages when reading CIB from disk (authored by kgaillot).
Log: pacemaker-based: improve messages when reading CIB from disk
Mar 5 2025, 11:28 AM
GitHub <noreply@github.com> committed rPa9afc90c0821: Merge pull request #3825 from clumens/logging (authored by clumens).
Merge pull request #3825 from clumens/logging
Mar 5 2025, 11:28 AM
clumens committed rPeb1081cf0e37: Log: pacemaker-based: improve exit messages (authored by kgaillot).
Log: pacemaker-based: improve exit messages
Mar 5 2025, 11:28 AM
clumens committed rP9ca219f2aac8: Log: controller: simplify join finalization messages (authored by kgaillot).
Log: controller: simplify join finalization messages
Mar 5 2025, 11:28 AM
clumens committed rP7747df0fb7a0: Log: pacemaker-based: improve a few messages (authored by kgaillot).
Log: pacemaker-based: improve a few messages
Mar 5 2025, 11:28 AM
clumens committed rP8eab0af5ad98: Log: controller: drop dot file logs (authored by kgaillot).
Log: controller: drop dot file logs
Mar 5 2025, 11:28 AM
clumens committed rP3cbec72bf4a5: Log: controller: improve start-up/exit messages (authored by kgaillot).
Log: controller: improve start-up/exit messages
Mar 5 2025, 11:28 AM
clumens committed rP97584ad1f289: Log: controller: improve resource action execution logs (authored by kgaillot).
Log: controller: improve resource action execution logs
Mar 5 2025, 11:28 AM
clumens committed rPc5ee89910c75: Build: devel: Add additional cppcheck arguments. (authored by clumens).
Build: devel: Add additional cppcheck arguments.
Mar 5 2025, 11:28 AM
clumens committed rPe636645eef86: Refactor: libs: Remove existing cppcheck suppressions. (authored by clumens).
Refactor: libs: Remove existing cppcheck suppressions.
Mar 5 2025, 11:28 AM
clumens committed rP9a4a52c47bd0: Refactor: daemons: Simplify some code in start_child. (authored by clumens).
Refactor: daemons: Simplify some code in start_child.
Mar 5 2025, 11:28 AM
clumens committed rPe31c9a8667e7: Refactor: libs: Add a couple new cppcheck suppressions. (authored by clumens).
Refactor: libs: Add a couple new cppcheck suppressions.
Mar 5 2025, 11:28 AM
clumens committed rP20bc479523c5: Build: Fix coverage targets. (authored by clumens).
Build: Fix coverage targets.
Mar 5 2025, 11:28 AM
GitHub <noreply@github.com> committed rPbe24948839e3: Merge pull request #3830 from clumens/coverage (authored by clumens).
Merge pull request #3830 from clumens/coverage
Mar 5 2025, 11:28 AM
GitHub <noreply@github.com> committed rR646a41d15d39: Merge pull request #2024 from oalbrigt/portblock-use-ocf_log (authored by oalbrigt).
Merge pull request #2024 from oalbrigt/portblock-use-ocf_log
Mar 5 2025, 11:23 AM
oalbrigt committed rR8a3328c07d8e: portblock: use ocf_log() for logging (authored by oalbrigt).
portblock: use ocf_log() for logging
Mar 5 2025, 11:23 AM
nrwahl2 added a comment to T973: Get rid of "non-option ARGV-elements" blocks from tools.

crm_resource already uses G_OPTION_REMAINING to collect the remaining arguments into an array. Then after parsing all options, it logs those remaining arguments if they're invalid. However, they're valid if we're running a subcommand that uses options.override_params.

Mar 5 2025, 11:23 AM · Restricted Project, Pacemaker: Tools
wenningerk updated the task description for T975: adhere node-attribute when colocating e.g. promoted role of one clone with promoted role of another.
Mar 5 2025, 11:23 AM · Pacemaker: Scheduler
nrwahl2 triaged T974: Error-check snprintf() calls as Wishlist priority.
Mar 5 2025, 11:23 AM · Pacemaker, Restricted Project
wenningerk triaged T975: adhere node-attribute when colocating e.g. promoted role of one clone with promoted role of another as Normal priority.
Mar 5 2025, 11:23 AM · Pacemaker: Scheduler

Feb 19 2025

clumens claimed T903: Split large IPC messages.
Feb 19 2025, 3:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens changed the status of T903: Split large IPC messages from Open to WIP.
Feb 19 2025, 3:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 18 2025

clumens triaged T973: Get rid of "non-option ARGV-elements" blocks from tools as Wishlist priority.
Feb 18 2025, 3:41 PM · Restricted Project, Pacemaker: Tools
clumens triaged T972: cts-cli shouldn't write to /tmp during package builds as Low priority.
Feb 18 2025, 1:33 PM · Restricted Project
clumens added a comment to T901: Use asynchronous communication for liblrmd commands with replies.

This is going to be very, very difficult to do which is why we've removed it from the RHEL board and lowered the priority. Basically, lrmd_send_command implements almost all of the API commands for a lrmd_t. All of those would need to be converted over to an async style, and then all of their callers would be. This includes major portions of the control daemon, which isn't very well set up to call the async versions of these functions. It would require rewriting much of liblrmd and the control daemon, and there's simply not enough time to get around to a project of that size.

Feb 18 2025, 1:24 PM · Restricted Project, Restricted Project
clumens added a comment to T775: Evaluate replacing pcmk__realloc() with GLib functions.

cppcheck appears to be fine with pcmk__realloc for me, but I would still be all for investigating removing it in favor of someone else's code.

Feb 18 2025, 1:10 PM · Restricted Project, Pacemaker: Libraries
nrwahl2 committed rPf94ad50b06ff: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Feb 18 2025, 9:19 AM
nrwahl2 committed rPd60b9407f2db: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Feb 18 2025, 9:19 AM
nrwahl2 committed rPa54c84e9bfb4: Fix: build: Fix default pacemaker-remoted path on Fedora >= 42 (authored by nrwahl2).
Fix: build: Fix default pacemaker-remoted path on Fedora >= 42
Feb 18 2025, 9:19 AM
nrwahl2 committed rPe6ed5ff165df: Refactor: libcrmcommon: Avoid unnecessary allocation for sbd paths (authored by nrwahl2).
Refactor: libcrmcommon: Avoid unnecessary allocation for sbd paths
Feb 18 2025, 9:19 AM
GitHub <noreply@github.com> committed rP1d6dcabd78bd: Merge pull request #3828 from nrwahl2/nrwahl2-sbindir21 (authored by clumens).
Merge pull request #3828 from nrwahl2/nrwahl2-sbindir21
Feb 18 2025, 9:19 AM
GitHub <noreply@github.com> committed rP64cd85422c19: Merge pull request #3827 from nrwahl2/nrwahl2-sbindir30 (authored by clumens).
Merge pull request #3827 from nrwahl2/nrwahl2-sbindir30
Feb 18 2025, 9:19 AM