Refactor: scheduler: best practices for pcmk__native_allocate()

Refactor: scheduler: rename pcmk__native_allocate()

Test: cts-cli,cts-scheduler: update expected output for function rename

Merge pull request #2827 from kgaillot/best-practices

Refactor: pacemaker-based: rename cib_is_master

Log: pacemaker-based: update primary terminology in messages and comments

Refactor: libcib: rename cib_client_is_master()

Refactor: libcib: rename cib_client_set_slave()

Refactor: libcib: rename cib_client_set_master()

Refactor: libcib: rename cib_client_set_slave_all()

API: libcib: deprecate cib_api_operations_t:is_master

API: libcib: deprecate cib_api_operations_t:set_slave_all

API: libcib: add cib_api_operations_t:set_primary

API: libcib: deprecate cib_api_operations_t:set_master

API: libcib: add cib_api_operations_t:set_secondary

API: libcib: deprecate cib_api_operations_t:set_slave

Merge pull request #2808 from kgaillot/term

Refactor: fencing: remove stonith_action_t victim member

Refactor: fencing: rename stonith_action_create()

Refactor: fencing: rename arguments to stonith_api_call()

Refactor: fencing: rename target arguments to make_args()

Doc: fencing: use target terminology consistently

Log: fencer: improve self-fencing logs

Merge pull request #2826 from kgaillot/fencing

Build: libcrmcommon: Rename GCC_FORMAT_NONLITERAL_CHECKING_ENABLED

Build: libcrmcommon: Rename SSCANF_HAS_M to HAVE_SSCANF_M

Build: libcrmcommon: Rename SUPPORT_DBUS to HAVE_DBUS

Build: various: Rename SUPPORT_PROCFS to HAVE_PROCFS

Build: libcrmcommon: Rename US_AUTH_GETPEEREID to HAVE_GETPEEREID

Build: libcrmcommon: Rename US_AUTH_PEERCRED_SOCKPEERCRED

Build: libcrmcommon: Rename US_AUTH_GETPEERUCRED to HAVE_GETPEERUCRED

Build: libcrmcommon: Rename US_AUTH_PEERCRED_UCRED to HAVE_UCRED

Merge pull request #2828 from nrwahl2/nrwahl2-T542

Low: libpe_status: Let pe__cmp_node_name() handle NULL values

Refactor: libpe_status: sort_rsc_priority() -> pe__cmp_rsc_priority()

Refactor: libpe_status: Rename sort_node_uname() pe__cmp_node_name()

Low: libcrmcommon: NULL-check pcmk__numeric_strcasecmp()

Test: libpe_status: Unit tests for pe__cmp_node_name()

Build: libpe_rules, libpe_status: Add -DPCMK__UNIT_TESTING to test libs

Build: libpe_status: Expose internal library functions for unit testing

Test: libpe_status: Unit tests for pe__cmp_rsc_priority()

Merge pull request #2820 from nrwahl2/nrwahl2-T534

Refactor: pacemaker-schedulerd: Constants for graph/config err/warn

Merge pull request #2825 from nrwahl2/nrwahl2-T541

Low: libcrmcommon: Define XML_RSC_ATTR_PROVIDES using defined constant

Fix: libcrmcommon: Correct typo in PCMK_XE_PROMOTABLE_LEGACY

API: libcrmcommon: add PCMK_XA_PROMOTED_MAX_LEGACY string constant

API: libcrmcommon: deprecate PCMK_XE_PROMOTED_MAX_LEGACY string constant

API: libcrmcommon: add PCMK_XA_PROMOTED_NODE_MAX_LEGACY string constant

API: libcrmcommon: deprecate PCMK_XE_PROMOTED_NODE_MAX_LEGACY constant

Merge pull request #2821 from nrwahl2/nrwahl2-T535

Refactor: libcrmcommon: Add io_internal.h

Refactor: libcrmcommon: Move string.h include to acl_internal.h

Merge pull request #2822 from nrwahl2/nrwahl2-T536

Low: controld: Update for OCF 1.1

Build: resources: Use runstatedir in controld RA

Low: controld: Check all crm_is_true cases for globally-unique

Merge pull request #2817 from nrwahl2/nrwahl2-T149

Build: scheduler: Add -fno-builtin -fno-inline for scheduler libraries.

Build: scheduler: Build the test libraries as shared libraries.

Merge pull request #2819 from clumens/pengine-test

Refactor: build: Move common test Makefile.am stuff into unittest.mk.

Refactor: tests: Add a PCMK__UNIT_TEST macro.

doc: Pacemaker Development: Update to describe latest test changes.

doc: Pacemaker Development: Explain code coverage.

Merge pull request #2810 from clumens/test-simplify

Test: cts-lab: Remove docker and phd

Test: cts-lab: Remove RemotePrimitives class

Merge pull request #2816 from nrwahl2/nrwahl2-T499

Mid: fenced: DC node fencing is unconditionally relayed.

Merge pull request #2815 from HideoYamauchi/fence_relay

Low: libcrmcommon: Validate env option strings

Refactor: libcrmcommon: Reduce duplication in env get/set

Test: libcrmcommon: Add unit tests for pcmk__env_option

Test: libcrmcommon: Mock setenv and unsetenv

Test: libcrmcommon: Unit tests for pcmk__set_env_option()

Test: libcrmcommon: Unit tests for pcmk__env_option_enabled()

Merge pull request #2801 from nrwahl2/nrwahl2-T493

Test: cts-cli: Prevent modification of crm_mon.xml

Merge pull request #2812 from nrwahl2/nrwahl2-T494

Refactor: scheduler: drop group_expand()

Refactor: scheduler: rename expand() method

Refactor: scheduler: move native_expand()

Refactor: scheduler: best practices for native_expand()

Refactor: scheduler: use bool instead of gboolean in create_probe() method

Refactor: scheduler: remove unused arguments to create_probe() method

Refactor: scheduler: move native_create_probe()

Refactor: scheduler: functionize adding expected probe result

Refactor: scheduler: functionize creating probes for a list of resources

Refactor: scheduler: functionize ordering start after probe

Refactor: scheduler: functionize checking whether guest will stop

Refactor: scheduler: functionize creating a probe action

Refactor: scheduler: best practices for native_create_probe()

Refactor: scheduler: functionize adding expected result to an action

Refactor: scheduler: use g_list_foreach() to add resource actions to graph

Merge pull request #2809 from kgaillot/best-practices

Test: cts: Reimplement cts-regression in Python

Merge pull request #2806 from nrwahl2/nrwahl2-T498

Refactor: libcrmcommon: PW_BUFFER_LEN utils.c -> crmcommon_private.h

Test: libcrmcommon: Check expectations in mocked getenv()